From 4d08053c2d76a5ae12e45e4665ad4c95cc2d41ea Mon Sep 17 00:00:00 2001 From: Julia Date: Tue, 7 Feb 2023 14:59:44 +0100 Subject: [PATCH 1/5] refactor(#3863): check expected logs --- .../roles/master-role/tasks/main.yml | 1 + .../roles/worker-role/tasks/main.yml | 1 + .../test_assign_groups_guess.py | 27 ++++++++++++------- 3 files changed, 19 insertions(+), 10 deletions(-) diff --git a/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml b/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml index 1d291790ab..45d6265d32 100644 --- a/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml +++ b/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml @@ -84,6 +84,7 @@ block: | authd.debug=2 wazuh_clusterd.debug=2 + remoted.debug=2 - name: Start Wazuh command: /var/ossec/bin/wazuh-control restart diff --git a/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml b/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml index c892778165..7252370014 100644 --- a/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml +++ b/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml @@ -84,6 +84,7 @@ block: | authd.debug=2 wazuh_clusterd.debug=2 + remoted.debug=2 - name: Restart Wazuh command: /var/ossec/bin/wazuh-control restart diff --git a/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py b/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py index 8f106cbe7b..1c211106a8 100644 --- a/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py +++ b/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py @@ -49,6 +49,8 @@ check_keys_file, delete_group_of_agents, remove_cluster_agents, assign_agent_to_new_group, restart_cluster) from wazuh_testing.tools.system import HostManager +from wazuh_testing.tools.file import replace_regex_in_file +from wazuh_testing.tools.monitoring import HostMonitor from wazuh_testing.tools import WAZUH_PATH @@ -59,6 +61,9 @@ inventory_path = os.path.join(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))), 'provisioning', 'enrollment_cluster', 'inventory.yml') +data_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data') +master_messages_path = os.path.join(data_path, 'guess_group_messages_master.yaml') +worker_messages_path = os.path.join(data_path, 'guess_group_messages_worker.yaml') host_manager = HostManager(inventory_path) local_path = os.path.dirname(os.path.abspath(__file__)) tmp_path = os.path.join(local_path, 'tmp') @@ -67,7 +72,7 @@ # Variables remoted_guess_agent_groups = 'remoted.guess_agent_group=' # this timeout is temporality, this test will be update -timeout = 60 +timeout = 20 # Tests @@ -88,15 +93,6 @@ def test_assign_agent_to_a_group(agent_target, status_guess_agent_group, clean_e - clean_enviroment: type: Fixture brief: Reset the wazuh log files at the start of the test. Remove all registered agents from master. - - test_infra_managers - type: List - brief: List of manager hosts in enviroment. - - test_infra_agents - type: List - brief: List of agent hosts in enviroment. - - host_manager - type: HostManager object - brief: Handles connection the enviroment's hosts. assertions: - Verify that after registering the agent key file exists in all nodes. - Verify that after registering the agent appears as never_connected in all nodes. @@ -154,8 +150,19 @@ def test_assign_agent_to_a_group(agent_target, status_guess_agent_group, clean_e # Check if remoted.guess_agent_group is disabled if(int(status_guess_agent_group) == 0): group_id = 'default' + # Run the callback checks for the ossec.log + if(agent_target == 'wazuh-master'): + messages_path = master_messages_path + else: + messages_path = worker_messages_path + + replace_regex_in_file(['AGENT_ID', 'GROUP_ID'], [agent_id, group_id], messages_path) + HostMonitor(inventory_path=inventory_path, + messages_path=messages_path, + tmp_path=tmp_path).run(update_position=True) check_agent_groups(agent_id, group_id, test_infra_managers, host_manager) finally: # Delete group of agent delete_group_of_agents(test_infra_managers[0], group_id, host_manager) + replace_regex_in_file([agent_id, group_id], ['AGENT_ID', 'GROUP_ID'], messages_path) From 894e66c6934b8f3119adf4bc9782592bf434f08d Mon Sep 17 00:00:00 2001 From: Julia Date: Tue, 7 Feb 2023 15:06:00 +0100 Subject: [PATCH 2/5] feat(#3863): update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e012d1b3d..30a2bddaba 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,7 @@ Release report: TBD ### Changed +- Improve `test_assign_groups_guess` ([#3901](https://github.com/wazuh/wazuh-qa/pull/3901)) \- (Tests) - Fix `test_agent_groups` ([#3889](https://github.com/wazuh/wazuh-qa/pull/3889)) \- (Tests + Framework) - Increase NVE download feed test timeout([#3769](https://github.com/wazuh/wazuh-qa/pull/3769)) \- (Tests) - Adapt wazuhdb integration tests for auto-vacuum ([#3613](https://github.com/wazuh/wazuh-qa/issues/3613)) \- (Tests) From 872f9001db358ce97eea9f5da883c71e5d8e4d7b Mon Sep 17 00:00:00 2001 From: Julia Date: Wed, 8 Feb 2023 10:31:02 +0100 Subject: [PATCH 3/5] feat(#3863): add messages --- .../data/guess_group_messages_master.yaml | 11 +++++++++++ .../data/guess_group_messages_worker.yaml | 18 ++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml create mode 100644 tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml diff --git a/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml new file mode 100644 index 0000000000..bb61075d70 --- /dev/null +++ b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml @@ -0,0 +1,11 @@ +--- +wazuh-master: + - regex: ".*Agent 'AGENT_ID' with file 'merged.mg' MD5 .*" + path: "/var/ossec/logs/ossec.log" + timeout: 30 + - regex: ".*Group assigned: 'GROUP_ID'" + path: "/var/ossec/logs/ossec.log" + timeout: 10 + - regex: ".*Agent 'AGENT_ID' group is 'GROUP_ID'" + path: "/var/ossec/logs/ossec.log" + timeout: 10 diff --git a/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml new file mode 100644 index 0000000000..a084c477a6 --- /dev/null +++ b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml @@ -0,0 +1,18 @@ +--- +wazuh-worker1: + - regex: ".*Sending message to master node: '{\"daemon_name\":\"remoted\",\"message\":{\"command\":\"assigngroup\",\"parameters\":{\"agent\":\"AGENT_ID\",\"md5\":.*" + path: "/var/ossec/logs/ossec.log" + timeout: 30 + - regex: ".*Message received from master node: '{\"error\":0,\"message\":\"ok\",\"data\":{\"group\":\"GROUP_ID\"}}'" + path: "/var/ossec/logs/ossec.log" + timeout: 10 + - regex: ".*Agent 'AGENT_ID' group is 'GROUP_ID'" + path: "/var/ossec/logs/ossec.log" + timeout: 10 +wazuh-master: + - regex: ".*Agent 'AGENT_ID' with file 'merged.mg' MD5 .*" + path: "/var/ossec/logs/ossec.log" + timeout: 30 + - regex: ".*Group assigned: 'GROUP_ID'" + path: "/var/ossec/logs/ossec.log" + timeout: 10 From 2c66ba119dfd76b580d6cd428391e07bf7cf142f Mon Sep 17 00:00:00 2001 From: Julia Date: Wed, 8 Feb 2023 13:09:13 +0100 Subject: [PATCH 4/5] fix(#3863): fix linter errors --- .../enrollment_cluster/playbook.yml | 17 +++--- .../agent-role/tasks/{main.yml => main.yaml} | 40 ++++++------- .../master-role/tasks/{main.yml => main.yaml} | 53 ++++++++--------- .../worker-role/tasks/{main.yml => main.yaml} | 59 +++++++++---------- .../vars/configurations.yaml | 12 ++++ .../vars/configurations.yml | 12 ---- .../enrollment_cluster/vars/main.yaml | 1 + .../enrollment_cluster/vars/main.yml | 2 - .../data/guess_group_messages_master.yaml | 11 ++-- .../data/guess_group_messages_worker.yaml | 18 +++--- .../test_assign_groups_guess.py | 9 +-- 11 files changed, 113 insertions(+), 121 deletions(-) rename tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/{main.yml => main.yaml} (60%) rename tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/{main.yml => main.yaml} (63%) rename tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/{main.yml => main.yaml} (59%) create mode 100644 tests/system/provisioning/enrollment_cluster/vars/configurations.yaml delete mode 100644 tests/system/provisioning/enrollment_cluster/vars/configurations.yml create mode 100644 tests/system/provisioning/enrollment_cluster/vars/main.yaml delete mode 100644 tests/system/provisioning/enrollment_cluster/vars/main.yml diff --git a/tests/system/provisioning/enrollment_cluster/playbook.yml b/tests/system/provisioning/enrollment_cluster/playbook.yml index 4ed9c9bd28..ca0bccbaf8 100644 --- a/tests/system/provisioning/enrollment_cluster/playbook.yml +++ b/tests/system/provisioning/enrollment_cluster/playbook.yml @@ -1,8 +1,7 @@ ---- - name: Create our container (Master) hosts: localhost vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml tasks: - name: Create a network docker_network: @@ -17,7 +16,7 @@ - name: Create our container (Worker1) hosts: localhost vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml tasks: - docker_container: name: "{{ worker1_hostname }}" @@ -29,7 +28,7 @@ - name: Create our container (Worker2) hosts: localhost vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml tasks: - docker_container: name: "{{ worker2_hostname }}" @@ -41,7 +40,7 @@ - name: Create our container (Agent1) hosts: localhost vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml tasks: - docker_container: name: "{{ agent1_hostname }}" @@ -55,7 +54,7 @@ vars: master_hostname: "wazuh-master" vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml roles: - name: "roles/master-role" @@ -64,7 +63,7 @@ vars: worker_name: wazuh-worker1 vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml roles: - name: "roles/worker-role" @@ -73,7 +72,7 @@ vars: worker_name: wazuh-worker2 vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml roles: - name: "roles/worker-role" @@ -83,6 +82,6 @@ manager_hostname: wazuh-master agent_hostname: "{{ agent1_hostname }}" vars_files: - - ./vars/configurations.yml + - ./vars/configurations.yaml roles: - name: "roles/agent-role" diff --git a/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yml b/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml similarity index 60% rename from tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yml rename to tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml index 06cea850a2..a8410a1f8e 100644 --- a/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yml +++ b/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml @@ -1,9 +1,9 @@ --- -- name: "Check and update debian repositories" +- name: Check and update debian repositories shell: cmd: apt-get update --allow-releaseinfo-change -- name: "Installing dependencies using apt" +- name: Installing dependencies using apt apt: pkg: - git @@ -23,9 +23,9 @@ update_cache: yes cache_valid_time: 3600 -- name: "Clone wazuh repository" +- name: Clone wazuh repository git: - repo: "https://github.com/wazuh/wazuh" + repo: https://github.com/wazuh/wazuh dest: /wazuh version: "{{ wazuh_branch }}" @@ -34,19 +34,19 @@ chdir: /wazuh creates: /var/ossec environment: - USER_LANGUAGE: "en" - USER_NO_STOP: "y" - USER_INSTALL_TYPE: "agent" - USER_DIR: "/var/ossec" - USER_ENABLE_EMAIL: "n" - USER_ENABLE_SYSCHECK: "y" - USER_ENABLE_ROOTCHECK: "y" - USER_ENABLE_OPENSCAP: "y" - USER_WHITE_LIST: "n" - USER_ENABLE_SYSLOG: "y" - USER_ENABLE_AUTHD: "y" - USER_AUTO_START: "y" - shell: "./install.sh" + USER_LANGUAGE: en + USER_NO_STOP: y + USER_INSTALL_TYPE: agent + USER_DIR: /var/ossec + USER_ENABLE_EMAIL: n + USER_ENABLE_SYSCHECK: y + USER_ENABLE_ROOTCHECK: y + USER_ENABLE_OPENSCAP: y + USER_WHITE_LIST: n + USER_ENABLE_SYSLOG: y + USER_ENABLE_AUTHD: y + USER_AUTO_START: y + shell: ./install.sh - name: Copy ossec.conf file copy: @@ -64,9 +64,9 @@ - name: Set Wazuh Manager IP lineinfile: path: /var/ossec/etc/ossec.conf - regexp: '
(.*)
' - line: "
{{ worker1_hostname }}
" - backrefs: yes + regexp:
(.*)
+ line:
{{ worker1_hostname }}
+ backrefs: true - name: enable agentd debug mode blockinfile: diff --git a/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml b/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yaml similarity index 63% rename from tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml rename to tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yaml index 45d6265d32..b1923a9654 100644 --- a/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yml +++ b/tests/system/provisioning/enrollment_cluster/roles/master-role/tasks/main.yaml @@ -1,9 +1,8 @@ ---- -- name: "Check and update debian repositories" +- name: Check and update debian repositories shell: cmd: apt-get update --allow-releaseinfo-change -- name: "Installing dependencies using apt" +- name: Installing dependencies using apt apt: pkg: - git @@ -17,14 +16,14 @@ - autoconf - libtool - libssl-dev - force_apt_get: yes + force_apt_get: true state: present - update_cache: yes + update_cache: true cache_valid_time: 3600 -- name: "Clone wazuh repository" +- name: Clone wazuh repository git: - repo: "https://github.com/wazuh/wazuh" + repo: https://github.com/wazuh/wazuh dest: /wazuh version: "{{ wazuh_branch }}" @@ -33,20 +32,20 @@ chdir: /wazuh creates: /var/ossec environment: - USER_LANGUAGE: "en" - USER_NO_STOP: "y" - USER_INSTALL_TYPE: "server" - USER_DIR: "/var/ossec" - USER_ENABLE_EMAIL: "n" - USER_ENABLE_SYSCHECK: "n" - USER_ENABLE_ROOTCHECK: "n" - USER_ENABLE_OPENSCAP: "n" - USER_WHITE_LIST: "n" - USER_ENABLE_SYSLOG: "y" - USER_ENABLE_AUTHD: "y" - USER_AUTO_START: "y" - USER_UPDATE: "n" - shell: "./install.sh" + USER_LANGUAGE: en + USER_NO_STOP: y + USER_INSTALL_TYPE: server + USER_DIR: /var/ossec + USER_ENABLE_EMAIL: n + USER_ENABLE_SYSCHECK: n + USER_ENABLE_ROOTCHECK: n + USER_ENABLE_OPENSCAP: n + USER_WHITE_LIST: n + USER_ENABLE_SYSLOG: y + USER_ENABLE_AUTHD: y + USER_AUTO_START: y + USER_UPDATE: n + shell: ./install.sh - name: Copy ossec.conf file copy: @@ -59,16 +58,16 @@ - name: Set cluster key lineinfile: path: /var/ossec/etc/ossec.conf - regexp: '(KEY)' - line: "{{ cluster_key }}" - backrefs: yes + regexp: (KEY) + line: {{ cluster_key }} + backrefs: true - name: Set Wazuh Master IP lineinfile: path: /var/ossec/etc/ossec.conf - regexp: '(.*)' - line: "{{ master_hostname }}" - backrefs: yes + regexp: (.*) + line: {{ master_hostname }} + backrefs: true - name: Stop Wazuh command: /var/ossec/bin/wazuh-control stop diff --git a/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml b/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yaml similarity index 59% rename from tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml rename to tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yaml index 7252370014..d113224ed1 100644 --- a/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yml +++ b/tests/system/provisioning/enrollment_cluster/roles/worker-role/tasks/main.yaml @@ -1,9 +1,8 @@ ---- -- name: "Check and update debian repositories" +- name: Check and update debian repositories shell: cmd: apt-get update --allow-releaseinfo-change -- name: "Installing dependencies using apt" +- name: Installing dependencies using apt apt: pkg: - git @@ -18,14 +17,14 @@ - libtool - python3-pytest - libssl-dev - force_apt_get: yes + force_apt_get: true state: present - update_cache: yes + update_cache: true cache_valid_time: 3600 -- name: "Clone wazuh repository" +- name: Clone wazuh repository git: - repo: "https://github.com/wazuh/wazuh" + repo: https://github.com/wazuh/wazuh dest: /wazuh version: "{{ wazuh_branch }}" @@ -34,20 +33,20 @@ chdir: /wazuh creates: /var/ossec environment: - USER_LANGUAGE: "en" - USER_NO_STOP: "y" - USER_INSTALL_TYPE: "server" - USER_DIR: "/var/ossec" - USER_ENABLE_EMAIL: "n" - USER_ENABLE_SYSCHECK: "y" - USER_ENABLE_ROOTCHECK: "y" - USER_ENABLE_OPENSCAP: "y" - USER_WHITE_LIST: "n" - USER_ENABLE_SYSLOG: "y" - USER_ENABLE_AUTHD: "y" - USER_AUTO_START: "y" - USER_UPDATE: "n" - shell: "./install.sh" + USER_LANGUAGE: en + USER_NO_STOP: y + USER_INSTALL_TYPE: server + USER_DIR: /var/ossec + USER_ENABLE_EMAIL: n + USER_ENABLE_SYSCHECK: y + USER_ENABLE_ROOTCHECK: y + USER_ENABLE_OPENSCAP: y + USER_WHITE_LIST: n + USER_ENABLE_SYSLOG: y + USER_ENABLE_AUTHD: y + USER_AUTO_START: y + USER_UPDATE: n + shell: ./install.sh - name: Copy ossec.conf file copy: @@ -60,23 +59,23 @@ - name: Set cluster key lineinfile: path: /var/ossec/etc/ossec.conf - regexp: '(KEY)' - line: "{{ cluster_key }}" - backrefs: yes + regexp: (KEY) + line: {{ cluster_key }} + backrefs: true - name: Set Wazuh Worker name lineinfile: path: /var/ossec/etc/ossec.conf - regexp: '(.*)' - line: "{{ worker_name }}" - backrefs: yes + regexp: (.*) + line: {{ worker_name }} + backrefs: true - name: Set Wazuh Worker IP lineinfile: path: /var/ossec/etc/ossec.conf - regexp: '(.*)' - line: "{{ master_hostname }}" - backrefs: yes + regexp: (.*) + line: {{ master_hostname }} + backrefs: true - name: enable authd and clusterd debug mode blockinfile: diff --git a/tests/system/provisioning/enrollment_cluster/vars/configurations.yaml b/tests/system/provisioning/enrollment_cluster/vars/configurations.yaml new file mode 100644 index 0000000000..24adc28c61 --- /dev/null +++ b/tests/system/provisioning/enrollment_cluster/vars/configurations.yaml @@ -0,0 +1,12 @@ +cluster_key: "00000000000000000000000000000000" + +master_hostname: wazuh-master + +worker1_hostname: wazuh-worker1 +worker2_hostname: wazuh-worker2 + +agent1_hostname: wazuh-agent1 + +docker_network: cluster_net + +image: dontpanicat/debian:buster diff --git a/tests/system/provisioning/enrollment_cluster/vars/configurations.yml b/tests/system/provisioning/enrollment_cluster/vars/configurations.yml deleted file mode 100644 index c36af502f3..0000000000 --- a/tests/system/provisioning/enrollment_cluster/vars/configurations.yml +++ /dev/null @@ -1,12 +0,0 @@ -cluster_key: "00000000000000000000000000000000" - -master_hostname: "wazuh-master" - -worker1_hostname: "wazuh-worker1" -worker2_hostname: "wazuh-worker2" - -agent1_hostname: "wazuh-agent1" - -docker_network: "cluster_net" - -image: "dontpanicat/debian:buster" diff --git a/tests/system/provisioning/enrollment_cluster/vars/main.yaml b/tests/system/provisioning/enrollment_cluster/vars/main.yaml new file mode 100644 index 0000000000..d55674a99b --- /dev/null +++ b/tests/system/provisioning/enrollment_cluster/vars/main.yaml @@ -0,0 +1 @@ +include_vars: configurations.yaml diff --git a/tests/system/provisioning/enrollment_cluster/vars/main.yml b/tests/system/provisioning/enrollment_cluster/vars/main.yml deleted file mode 100644 index a0bc7d5fd3..0000000000 --- a/tests/system/provisioning/enrollment_cluster/vars/main.yml +++ /dev/null @@ -1,2 +0,0 @@ ---- -include_vars: "configurations.yml" \ No newline at end of file diff --git a/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml index bb61075d70..d7a718a22b 100644 --- a/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml +++ b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_master.yaml @@ -1,11 +1,10 @@ ---- wazuh-master: - - regex: ".*Agent 'AGENT_ID' with file 'merged.mg' MD5 .*" - path: "/var/ossec/logs/ossec.log" + - regex: .*Agent 'AGENT_ID' with file 'merged.mg' MD5 .* + path: var/ossec/logs/ossec.log timeout: 30 - regex: ".*Group assigned: 'GROUP_ID'" - path: "/var/ossec/logs/ossec.log" + path: /var/ossec/logs/ossec.log timeout: 10 - - regex: ".*Agent 'AGENT_ID' group is 'GROUP_ID'" - path: "/var/ossec/logs/ossec.log" + - regex: .*Agent 'AGENT_ID' group is 'GROUP_ID' + path: /var/ossec/logs/ossec.log timeout: 10 diff --git a/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml index a084c477a6..096bb776d1 100644 --- a/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml +++ b/tests/system/test_cluster/test_agent_groups/data/guess_group_messages_worker.yaml @@ -1,18 +1,18 @@ ---- wazuh-worker1: - - regex: ".*Sending message to master node: '{\"daemon_name\":\"remoted\",\"message\":{\"command\":\"assigngroup\",\"parameters\":{\"agent\":\"AGENT_ID\",\"md5\":.*" - path: "/var/ossec/logs/ossec.log" + - regex: ".*Sending message to master node: '{\"daemon_name\":\"remoted\",\"message\":{\"command\":\"assigngroup\",\ + \"parameters\":{\"agent\":\"AGENT_ID\",\"md5\":.*" + path: /var/ossec/logs/ossec.log timeout: 30 - regex: ".*Message received from master node: '{\"error\":0,\"message\":\"ok\",\"data\":{\"group\":\"GROUP_ID\"}}'" - path: "/var/ossec/logs/ossec.log" + path: /var/ossec/logs/ossec.log timeout: 10 - - regex: ".*Agent 'AGENT_ID' group is 'GROUP_ID'" - path: "/var/ossec/logs/ossec.log" + - regex: .*Agent 'AGENT_ID' group is 'GROUP_ID' + path: /var/ossec/logs/ossec.log timeout: 10 wazuh-master: - - regex: ".*Agent 'AGENT_ID' with file 'merged.mg' MD5 .*" - path: "/var/ossec/logs/ossec.log" + - regex: .*Agent 'AGENT_ID' with file 'merged.mg' MD5 .* + path: /var/ossec/logs/ossec.log timeout: 30 - regex: ".*Group assigned: 'GROUP_ID'" - path: "/var/ossec/logs/ossec.log" + path: /var/ossec/logs/ossec.log timeout: 10 diff --git a/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py b/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py index 1c211106a8..027aa8eb63 100644 --- a/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py +++ b/tests/system/test_cluster/test_agent_groups/test_assign_groups_guess.py @@ -148,13 +148,10 @@ def test_assign_agent_to_a_group(agent_target, status_guess_agent_group, clean_e time.sleep(timeout) # Check if remoted.guess_agent_group is disabled - if(int(status_guess_agent_group) == 0): - group_id = 'default' + group_id = 'default' if int(status_guess_agent_group) == 0 else group_id + # Run the callback checks for the ossec.log - if(agent_target == 'wazuh-master'): - messages_path = master_messages_path - else: - messages_path = worker_messages_path + messages_path = master_messages_path if agent_target == 'wazuh-master' else worker_messages_path replace_regex_in_file(['AGENT_ID', 'GROUP_ID'], [agent_id, group_id], messages_path) HostMonitor(inventory_path=inventory_path, From 97c1fd452b1fb0f27fb039a26ecd23bfb159d5a1 Mon Sep 17 00:00:00 2001 From: Julia Date: Wed, 8 Feb 2023 13:11:50 +0100 Subject: [PATCH 5/5] fix(#3863): fix linter errors --- .../provisioning/enrollment_cluster/playbook.yml | 10 +++++----- .../roles/agent-role/tasks/main.yaml | 5 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/tests/system/provisioning/enrollment_cluster/playbook.yml b/tests/system/provisioning/enrollment_cluster/playbook.yml index ca0bccbaf8..285aa3de3d 100644 --- a/tests/system/provisioning/enrollment_cluster/playbook.yml +++ b/tests/system/provisioning/enrollment_cluster/playbook.yml @@ -52,11 +52,11 @@ - name: Wazuh Master hosts: wazuh-master vars: - master_hostname: "wazuh-master" + master_hostname: wazuh-master vars_files: - ./vars/configurations.yaml roles: - - name: "roles/master-role" + - name: roles/master-role - name: Wazuh Worker1 hosts: wazuh-worker1 @@ -65,7 +65,7 @@ vars_files: - ./vars/configurations.yaml roles: - - name: "roles/worker-role" + - name: roles/worker-role - name: Wazuh Worker2 hosts: wazuh-worker2 @@ -74,7 +74,7 @@ vars_files: - ./vars/configurations.yaml roles: - - name: "roles/worker-role" + - name: roles/worker-role - name: Wazuh Agent1 hosts: wazuh-agent1 @@ -84,4 +84,4 @@ vars_files: - ./vars/configurations.yaml roles: - - name: "roles/agent-role" + - name: roles/agent-role diff --git a/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml b/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml index a8410a1f8e..a10142aeab 100644 --- a/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml +++ b/tests/system/provisioning/enrollment_cluster/roles/agent-role/tasks/main.yaml @@ -1,4 +1,3 @@ ---- - name: Check and update debian repositories shell: cmd: apt-get update --allow-releaseinfo-change @@ -18,9 +17,9 @@ - libtool - python3-pytest - libssl-dev - force_apt_get: yes + force_apt_get: true state: present - update_cache: yes + update_cache: true cache_valid_time: 3600 - name: Clone wazuh repository