From bcd35b70e0da01fe9c2021759cf819d89770f880 Mon Sep 17 00:00:00 2001 From: Shubham Dubey Date: Mon, 7 Aug 2023 01:02:26 +0530 Subject: [PATCH 1/2] added the functionality to introduce different timeout value for Web3BatchRequest --- packages/web3-core/src/web3_batch_request.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/web3-core/src/web3_batch_request.ts b/packages/web3-core/src/web3_batch_request.ts index c232a4edc9a..10a3eaf4693 100644 --- a/packages/web3-core/src/web3_batch_request.ts +++ b/packages/web3-core/src/web3_batch_request.ts @@ -48,13 +48,15 @@ export class Web3BatchRequest { } // eslint-disable-next-line class-methods-use-this - public async execute(): Promise> { + public async execute(options?: { + timeout?: number; + }): Promise> { if (this.requests.length === 0) { return Promise.resolve([]); } const request = new Web3DeferredPromise>({ - timeout: DEFAULT_BATCH_REQUEST_TIMEOUT, + timeout: options?.timeout ?? DEFAULT_BATCH_REQUEST_TIMEOUT, eagerStart: true, timeoutMessage: 'Batch request timeout', }); From 2cf6224380c3b6334f37786252e890f01f5b1580 Mon Sep 17 00:00:00 2001 From: Shubham Dubey Date: Tue, 15 Aug 2023 00:50:15 +0530 Subject: [PATCH 2/2] update the pr details to changelog --- packages/web3-core/CHANGELOG.md | 1 + packages/web3/CHANGELOG.md | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/web3-core/CHANGELOG.md b/packages/web3-core/CHANGELOG.md index 66428cbae54..f7b689b6762 100644 --- a/packages/web3-core/CHANGELOG.md +++ b/packages/web3-core/CHANGELOG.md @@ -162,3 +162,4 @@ Documentation: ## Added - Added minimum support of web3.extend function +- To fix issue #6190, added the functionality to introduce different timeout value for Web3. (#6336) diff --git a/packages/web3/CHANGELOG.md b/packages/web3/CHANGELOG.md index f15fc5c45fd..7d6a4aea947 100644 --- a/packages/web3/CHANGELOG.md +++ b/packages/web3/CHANGELOG.md @@ -138,3 +138,4 @@ Documentation: ## Added - Added minimum support of web3.extend function +- To fix issue #6190, added the functionality to introduce different timeout value for Web3. (#6336)