Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding revoke push notification #594

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: adding revoke push notification #594

merged 1 commit into from
Jan 19, 2024

Conversation

javip97
Copy link
Contributor

@javip97 javip97 commented Jan 9, 2024 •
edited
Loading

waiting for mobile implementation

16-01 -> Already tested with mobile and working

@javip97 javip97 added backend do not merge Please, do not merge it. labels Jan 9, 2024
@javip97 javip97 self-assigned this Jan 9, 2024
@javip97 javip97 requested a review from a team as a code owner January 9, 2024 09:41
@javip97 javip97 removed the do not merge Please, do not merge it. label Jan 19, 2024
martinsaporiti
martinsaporiti approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@martinsaporiti martinsaporiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x1m3
x1m3 requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@x1m3 x1m3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a request change to return list of Claims instead of list of pointers to Claims

internal/core/ports/claims_service.go Show resolved Hide resolved
x1m3
x1m3 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@x1m3 x1m3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's do the refactor proposed in a previous comment in other PR as it will add a lot of noise to this. Sorry

@javip97 javip97 merged commit 91a6175 into develop Jan 19, 2024
3 checks passed
@javip97 javip97 deleted the PID-1236-issuer-node-revocation-auth-push-notifications branch January 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinsaporiti martinsaporiti martinsaporiti approved these changes

@x1m3 x1m3 x1m3 approved these changes

Assignees

@javip97 javip97

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javip97 @martinsaporiti @x1m3