Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update identity state for mtp credentials #644

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix: update identity state for mtp credentials #644

merged 3 commits into from
Apr 5, 2024

Conversation

martinsaporiti
Copy link
Contributor

No description provided.

@martinsaporiti martinsaporiti requested a review from a team as a code owner April 5, 2024 10:22
@martinsaporiti martinsaporiti self-assigned this Apr 5, 2024
@martinsaporiti martinsaporiti added bug Something isn't working backend labels Apr 5, 2024
x1m3
x1m3 reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@x1m3 x1m3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a comment regarding a constant that probably we could reuse

internal/core/services/identity.go Outdated Show resolved Hide resolved
@javip97 javip97 mentioned this pull request Apr 5, 2024
Closed
javip97
javip97 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@javip97 javip97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x1m3
x1m3 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@x1m3 x1m3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinsaporiti martinsaporiti merged commit e1e2edd into develop Apr 5, 2024
3 checks passed
@martinsaporiti martinsaporiti deleted the PID-2042-issuer-node-fix-update-identity-state-for-mtp-credentials branch April 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x1m3 x1m3 x1m3 approved these changes

@javip97 javip97 javip97 approved these changes

Assignees

@martinsaporiti martinsaporiti

Labels
backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinsaporiti @x1m3 @javip97