feat: Support disable flag for mediatype validator #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsaporiti
approved these changes
Jun 20, 2024
vmidyllic
reviewed
Jun 20, 2024
x1m3
changed the title
vmidyllic
reviewed
Jun 20, 2024
internal/config/config.go
Outdated
| @@ -634,6 +644,11 @@ func checkEnvVars(ctx context.Context, cfg *Configuration) { | |||
| cfg.AutoPublishingToOnChainRHS = common.ToPointer(true) | |||
| } | |||
|
|
|||
| if cfg.MediaTypeManager.StrictMode == nil { | |||
| log.Info(ctx, "ISSUER_MEDIA_TYPE_MANAGER_STRICT_MODE is missing and the server set up it as true") | |||
There was a problem hiding this comment.
server set up it as true? how is that possible? why do we need it? default value, which can be overwritten by config. You will need then always to set it? That's not a plan. Now I even don't know why we need both enabled and strict mode
pkg/protocol/verify.go
Outdated
Comment on lines
28
to
33
| // bytePubsig, err := json.Marshal(pubsignals) | ||
| // if err != nil { | ||
| // return err | ||
| // } | ||
|
|
||
| // authPubSignals := circuits.AuthV2PubSignals{} |
There was a problem hiding this comment.
do you need to comment everything???
There was a problem hiding this comment.
miss this. sorry. I did some tests yesterday.
martinsaporiti
approved these changes
Jun 20, 2024
martinsaporiti
approved these changes
Jun 20, 2024
| @@ -201,6 +202,11 @@ type APIUIAuth struct { | |||
| Password string `mapstructure:"Password" tip:"Server UI API Basic auth password"` | |||
| } | |||
|
|
|||
| // MediaTypeManager enables or disables the media types manager | |||
| type MediaTypeManager struct { | |||
| Enabled *bool `mapstructure:"Enabled" tip:"Enable or disable the media type manager"` | |||
There was a problem hiding this comment.
update .env file sample, please
| @@ -51,6 +51,7 @@ type Configuration struct { | |||
| CredentialStatus CredentialStatus `mapstructure:"CredentialStatus"` | |||
| CustomDIDMethods []CustomDIDMethods `mapstructure:"-"` | |||
| AutoPublishingToOnChainRHS *bool `mapstructure:"AutoPublishingToOnChainRHS"` | |||
| MediaTypeManager MediaTypeManager `mapstructure:"MediaTypeManager"` | |||
There was a problem hiding this comment.
update env file sample, please
| &merkletree.HashZero, | ||
| &merkletree.HashZero, | ||
| }, | ||
| if len(rhsPublishers) > 0 && !(rhsMode == reverse_hash.RHSModeOnChain && !i.autoPublishingToOnChainRHS) { |
There was a problem hiding this comment.
this should be documented in the readme or in a good document in notion
ilya-korotya
deleted the
feature/support-disable-flag-for-mediatype-checker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.