Fix screenshots getting force downloaded #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix screenshots getting force downloaded when clicking them https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/
|
From an ideal perspective this would be a separate step in the workflow files as opposed to running inside the action, but I recognize that that's probably not very practical and could introduce other issues with the way are creating workflow files - as it is, there seems to be a fair amount of confusion over just getting a basic file set up. For this particular change, I would also like to see the same change made in the asset update action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix screenshots getting force downloaded when clicking them https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/
I guess its best run last b4 commit. The
|| trueis because it will fail if there is nothing to do no images (probably both, not sure). So it will not stop the entire script.