Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace URL & Add Notice #787

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Replace URL & Add Notice #787

merged 2 commits into from
Aug 2, 2024

Conversation

faisal-alvi
Copy link
Member

Description of the Change

  • This PR fixes
  • Also adds an error notice to the ComputerVision provider.

image

How to test the Change

In develop branch, try to add an invalid API key and see it does not show any error notice. This PR shows it.

Changelog Entry

Added - An error notice for ComputerVision provider
Changed - URLs replaced from the Old ClassifAI theme with the new FSE-based theme

Credits

Props @dkotter @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi added this to the Future Release milestone Aug 2, 2024
@faisal-alvi faisal-alvi self-assigned this Aug 2, 2024
@faisal-alvi faisal-alvi changed the title Fix url add notice Replace URL & Add Notice Aug 2, 2024
@faisal-alvi faisal-alvi requested review from jeffpaul and a team and removed request for a team and jeffpaul August 2, 2024 16:46
@faisal-alvi faisal-alvi marked this pull request as ready for review August 2, 2024 16:46
@faisal-alvi faisal-alvi requested review from dkotter, jeffpaul and a team as code owners August 2, 2024 16:46
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 2, 2024
@dkotter dkotter modified the milestones: Future Release, 3.1.1 Aug 2, 2024
@dkotter dkotter merged commit afda726 into develop Aug 2, 2024
17 checks passed
@dkotter dkotter deleted the fix-url-add-notice branch August 2, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees

@faisal-alvi faisal-alvi

Labels
needs:code-review This requires code review.
Projects
Open Source Practice
Archived in project
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@faisal-alvi @dkotter