Update our GitHub Action Workflows #810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we cache composer dependencies to make things faster
…have changed. Also only run PHPCS on changed lines of PHP files, not the entire file
jeffpaul
reviewed
Sep 27, 2024
| @@ -31,6 +32,6 @@ jobs: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| with: | |||
| upload_url: ${{ github.event.release.upload_url }} | |||
| asset_path: ${{github.workspace}}/classifai.zip | |||
| asset_path: ${{ github.workspace }}/classifai.zip | |||
There was a problem hiding this comment.
lol is it this spacing that was breaking releases not including the classifai.zip file?
There was a problem hiding this comment.
I doubt it but I guess we'll see 🤷🏻
jeffpaul
reviewed
Sep 27, 2024
| @@ -18,6 +19,6 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: WordPress version checker | |||
| uses: skaut/wordpress-version-checker@v2.0.0 | |||
| uses: skaut/wordpress-version-checker@v2.2.1 | |||
There was a problem hiding this comment.
any reason to just truncate that to v2 and get all minor updates along the way?
There was a problem hiding this comment.
I initially tried that but there isn't a valid v2 release to make that work. If you try to go to https:/skaut/wordpress-version-checker/tree/v2/ it will 404, so the only thing I could get to work was the specific release number
jeffpaul
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR brings various updates to our GitHub Action Workflows:
How to test the Change
Ensure all Actions run properly on this PR
Changelog Entry
Credits
Props @dkotter
Checklist: