Fix type of HtmlTransformer plugins attribute #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While plugins should be ordered, this attribute seems to be used as a map from an extension to that list of plugins rather than the list itself; as indicated in the `getPlugins()` method. In my site I don't do any configuration of this, just using the defaults. While trying to update to Eleventy 3 I was running into errors > Problem writing Eleventy templates: > 1. Having trouble writing to "./public/css/base.css", "./public/css/base.css.map" from "./pages/styles.11ty.js" (via EleventyTemplateError) > 2. Transform `@11ty/eleventy/html-transformer` encountered an error when transforming ./pages/styles.11ty.js. (via EleventyTransformError) > 3. plugins is not iterable (via TypeError) > > Original error stack trace: TypeError: plugins is not iterable > at HtmlTransformer._getPosthtmlInstance (file:///home/ats/vc/personal/web/node_modules/.pnpm/github.com+11ty+eleventy@c39e896/node_modules/@11ty/eleventy/src/Util/HtmlTransformer.js:39:39) > at HtmlTransformer.transformContent (file:///home/ats/vc/personal/web/node_modules/.pnpm/github.com+11ty+eleventy@c39e896/node_modules/@11ty/eleventy/src/Util/HtmlTransformer.js:142:42) > at Object.<anonymous> (file:///home/ats/vc/personal/web/node_modules/.pnpm/github.com+11ty+eleventy@c39e896/node_modules/@11ty/eleventy/src/defaultConfig.js:125:13) > at Object.fn (file:///home/ats/vc/personal/web/node_modules/.pnpm/github.com+11ty+eleventy@c39e896/node_modules/@11ty/eleventy/src/Benchmark/BenchmarkGroup.js:37:23) > at TransformsUtil.runAll (file:///home/ats/vc/personal/web/node_modules/.pnpm/github.com+11ty+eleventy@c39e896/node_modules/@11ty/eleventy/src/Util/TransformsUtil.js:36:30) The main problem seemed to be writing `./public/css/base.css.map`. When getPlugins was called for that it was finding the `map` method for Array which it could not iterate over.
zachleat
approved these changes
Aug 8, 2024
|
Thank you! This will ship with 3.0.0-canary.19, 3.0.0-beta.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While plugins should be ordered, this attribute seems to be used as a map from an extension to that list of plugins rather than the list itself; as indicated in the
getPlugins()method.In my site I don't do any configuration of this, just using the defaults. While trying to update to Eleventy 3 I was running into errors
The main problem seemed to be writing
./public/css/base.css.map. When getPlugins was called for that it was finding themapmethod for Array which it could not iterate over.