Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

safer starting of the server #464

Merged
merged 3 commits into from
Jun 22, 2018
Merged

safer starting of the server #464

merged 3 commits into from
Jun 22, 2018

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Jun 22, 2018

See commits.

@afeld
exit running the server if one of the containers exists
d07cf85 
It's easy to miss a container exiting prematurely in all the other log
output, so this will stop the server entirely if any of the services
fail to start or crash.
@afeld
always build containers when starting the server
fcdb298 
The containers need to be rebuilt in certain cases (NPM dependencies
change, etc.) - this flag ensures that happens every time the server
starts. This should help avoid confusing errors around containers being
out-of-date, with the caveat that this will slow down startup a bit.
@afeld
ignore additional files from Docker builds
3d4c280 
Slightly reduces the number of files sent to the Docker host for
building.
@afeld afeld requested a review from ryanhofdotgov June 22, 2018 17:20
@ryanhofdotgov ryanhofdotgov merged commit 26b0184 into develop Jun 22, 2018
@ryanhofdotgov ryanhofdotgov deleted the build-better branch June 22, 2018 17:35
@afeld
Copy link
Contributor Author

afeld commented Jun 22, 2018

More about the issue here: docker/compose#4337 A bit unclear what the current recommended setup for this would be.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanhofdotgov ryanhofdotgov ryanhofdotgov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afeld @ryanhofdotgov @michaelccata