New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove `globalDefer` #24

Merged

18alantom merged 2 commits into main from remove-defer-use-maps

Jul 10, 2023

Owner

18alantom commented Jul 10, 2023 •

edited

Loading

globalDefer was used to defer dom updates when:

document readyState was still loading
sb was initialized in a <script> with <head> parent

This is bad cause it isn't explicit causing code to work in unexpected ways.

This can be taken care of by running the code in an <script async> tag or a <script type="module"> tag (esm imports to be added in the future).

18alantom added 2 commits

July 10, 2023 21:20


remove use of globalDefer

b7674c1


remove defer tests

5d8ac6d

18alantom marked this pull request as ready for review

July 10, 2023 16:00

18alantom merged commit 3619f1d into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment