[jade.xyz] 방탈출 인증 관리 step3 과제 제출 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayden-17
approved these changes
Feb 1, 2023
| # Step 3 | ||
|
|
||
| ## 기능 요구사항 |
|
|
||
| @RestController | ||
| @RequestMapping("/admin/themes") | ||
| public class AdminController { |
There was a problem hiding this comment.
기존 ThemeController 와 AdminController 를 분리 👍
| return HandlerInterceptor.super.preHandle(request, response, handler); | ||
| } | ||
|
|
||
| private void checkIsValidToken(HttpServletRequest request, HttpServletResponse response, String accessToken) throws ServletException, IOException { |
| import javax.servlet.http.HttpServletRequest; | ||
|
|
||
| @RestController | ||
| public class ExceptionController { |
There was a problem hiding this comment.
별도 예외 처리를 위한 controller 보다는 ExceptionHandler 로 유도할 수는 없을까요 ?
| private Long themeId; | ||
| private String date; | ||
| private String time; | ||
| private final Long themeId; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이번 과제는 테마 관리는 관리자만 할 수 있도록 관리자 권한을 추가하는 내용이었습니다.
Member 필드와 accessToken에 role을 추가하였고
권한 확인을 위한 Interceptor를 추가하였습니다.
추가로 생성자 관련해서 문제가 있던 부분은 ReservationRequest이었고 ReservationE2ETest에서 실패합니다.