Add example sketch for half-duplex RS485 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RS485_HalfDuplex.pde - example using ModbusMaster library | ||
|
|
||
| This example is tested against an EPSolar LS2024B solar charge controller. | ||
| See here for protocol specs: http://www.solar-elektro.cz/data/dokumenty/1733_modbus_protocol.pdf |
There was a problem hiding this comment.
style: wrap @ 78 (ref. AV Rule 41)
|
@kintel thanks for the half-duplex example. Looks pretty good. I've annotated a few lines with minor style issues (line length, brace position). Ready to merge after updates. |
|
LGTM. I'm going to merge this so I can finish adjusting license text. Open a separate issue/PR if the hardware test reveals a bug. |
4-20ma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #44.
Note: This has not yet been tested on actual hardware, but feel free to review code in the meantime.
TODO: