Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default url logic #269

Merged
merged 13 commits into from
May 2, 2024
Merged

fix: default url logic #269

merged 13 commits into from
May 2, 2024

Conversation

chanhihi
Copy link
Member

@chanhihi chanhihi commented May 2, 2024 •
edited
Loading

๐Ÿ“Œ ๊ฐœ์š”

  • default logic์„ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.
  • favorite default ๋ฅผ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.
  • folder๋ฅผ ์ „๋ถ€ ์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • how to use๋กœ ์—ฐ๊ฒฐ๋˜๊ฒŒ๋งŒ ํ•ด๋’€์Šต๋‹ˆ๋‹ค.

๐Ÿ’ป ์ž‘์—… ๋‚ด์šฉ

  • How to use
  • Readme
  • default logic

@chanhihi chanhihi added ๐Ÿž Bug Something isn't working ๐Ÿ“„ Documentation Improvements or additions to documentation labels May 2, 2024
@chanhihi chanhihi requested a review from noeyiz May 2, 2024 14:45
@chanhihi chanhihi self-assigned this May 2, 2024
@chanhihi chanhihi linked an issue May 2, 2024 that may be closed by this pull request
fix: default url logic #268
Closed
noeyiz
noeyiz approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@noeyiz noeyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šด๋‹ค ใ…  _ ใ…  ์ด๋ฒˆ์—” ๋ถ€๋”” ์‹ฌ์‚ฌ ํ†ต๊ณผํ•˜๊ธธ ... ๐Ÿ™๐Ÿป

@chanhihi chanhihi requested review from JH713 and jonnwon May 2, 2024 16:16
@chanhihi chanhihi marked this pull request as ready for review May 2, 2024 16:18
@chanhihi chanhihi merged commit 49c2865 into develop May 2, 2024
1 check passed
@chanhihi chanhihi deleted the 268-fix-default-url-logic branch May 2, 2024 16:19
chanhihi added a commit that referenced this pull request May 2, 2024
@chanhihi
Main Version 1.0.1 (#270)
9aeccfb 
fix: default url logic (#269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noeyiz noeyiz noeyiz approved these changes

@JH713 JH713 Awaiting requested review from JH713

@jonnwon jonnwon Awaiting requested review from jonnwon

Assignees

@chanhihi chanhihi

Labels
๐Ÿž Bug Something isn't working ๐Ÿ“„ Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: default url logic
2 participants
@chanhihi @noeyiz