Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move fully to Python 3 #50

Merged
merged 4 commits into from
Oct 4, 2019
Merged

refactor: Move fully to Python 3 #50

merged 4 commits into from
Oct 4, 2019

Conversation

taion
Copy link
Contributor

@taion taion commented Oct 4, 2019

No description provided.

@taion taion requested review from c0state and itajaja October 4, 2019 04:03
@taion
Copy link
Contributor Author

taion commented Oct 4, 2019

We should pull more of our S3 stuff into here as well.

@taion
Copy link
Contributor Author

taion commented Oct 4, 2019

@c0state if this looks good to you, i'll cut a release after we merge

@sloria
Copy link
Member

sloria commented Oct 4, 2019

Running pyupgrade gave this

diff --git a/flask_annex/file.py b/flask_annex/file.py
index 51c0964..5812bee 100644
--- a/flask_annex/file.py
+++ b/flask_annex/file.py
@@ -88,7 +88,7 @@ class FileAnnex(AnnexBase):
 
         # Verify that we aren't trying to create the root path.
         if not os.path.exists(self._root_path):
-            raise IOError(
+            raise OSError(
                 f"root path {self._root_path} does not exist",
             )
 

Otherwise this lgtm.

@taion
Copy link
Contributor Author

taion commented Oct 4, 2019

ah, it should be a FileNotFoundError anyway

@taion taion merged commit 279c329 into master Oct 4, 2019
@taion taion deleted the py3 branch October 4, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants