Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] WAI-ARIA 1.3 update #557

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Breaking] WAI-ARIA 1.3 update #557

wants to merge 3 commits into from

Conversation

jlp-craigmorten
Copy link
Contributor

@jlp-craigmorten jlp-craigmorten commented Jul 5, 2024 •
edited
Loading

Description

Fixes #556

Branch tracking the WAI-ARIA 1.3 Roles Model.

See https://www.w3.org/TR/wai-aria-1.3/#changelog for the 1.3 changelog.

Key Changes

Let me know if the 1.2 relevant fixes should be extracted into a separate fix PR.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 5, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9805951235

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.842%
Totals Coverage Status
Change from base Build 9799525368: 0.04%
Covered Lines: 260
Relevant Lines: 266
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9805970558

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.842%
Totals Coverage Status
Change from base Build 9799525368: 0.04%
Covered Lines: 260
Relevant Lines: 266
💛 - Coveralls

ljharb
ljharb reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many parts of this seem additive, but unfortunately some parts seem breaking.

src/etc/roles/literal/markRole.js Show resolved Hide resolved
src/etc/roles/literal/noneRole.js Show resolved Hide resolved
@cmorten cmorten mentioned this pull request Jul 6, 2024
Merged
@jlp-craigmorten jlp-craigmorten changed the title WAI-ARIA 1.3 update feat: WAI-ARIA 1.3 update Jul 6, 2024
@jlp-craigmorten
Copy link
Contributor Author

jlp-craigmorten commented Jul 6, 2024 •
edited
Loading

Many parts of this seem additive, but unfortunately some parts seem breaking.

@ljharb see replies - in all cases the changes are either bugfixes to adhere to the WAI-ARIA 1.2 spec, or additive changes for the WAI-ARIA 1.3 spec.

Unless we consider amending incorrect data to match the spec to be a breaking change I'm leaning to disagreeing on that. However, we might want to consider updating to WAI-ARIA 1.3 a breaking change despite it's changes (thus far afaik) being additive.

Update: I stand corrected, this is a combination of bugfixes, 1.3 breaking changes, and 1.3 additive changes. I would definitely consider this a major change as stands.

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9821770687

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.842%
Totals Coverage Status
Change from base Build 9799525368: 0.04%
Covered Lines: 260
Relevant Lines: 266
💛 - Coveralls

@cmorten cmorten mentioned this pull request Jul 7, 2024
Open
14 tasks
@coveralls
Copy link

coveralls commented Jul 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10141401372

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 96.766%
Totals Coverage Status
Change from base Build 9879751240: 0.3%
Covered Lines: 288
Relevant Lines: 292
💛 - Coveralls

@jlp-craigmorten jlp-craigmorten marked this pull request as ready for review July 8, 2024 12:26
@jlp-craigmorten @ljharb
feat: add new comment, image, and suggestion roles
dfcb8ca 
TODO: update existing role props with `aria-braillelabel`, `aria-brailleroledescription`, and `aria-description`
@jlp-craigmorten @ljharb
feat: update role states and properties
7ba68c1 
* Addition of `aria-braillelabel`
* Addition of `aria-brailleroledescription`
* Addition of `aria-description`
* Fixes to some `prohibitedProps` and `nameFrom` fields
@jlp-craigmorten @ljharb
docs: README update
9513647
@ljharb ljharb changed the title feat: WAI-ARIA 1.3 update [Breaking] WAI-ARIA 1.3 update Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: WAI-ARIA 1.3 Roles Model Support
3 participants
@jlp-craigmorten @coveralls @ljharb