Update summary.md #125
Merged
Update summary.md #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang2yn84
reviewed
Jun 13, 2024
FanhaiLu1
approved these changes
Jun 13, 2024
| @@ -22,6 +22,8 @@ Date | Device | dtype | batch size | cache length |max input length |max output | |||
| ----| ------- | ------ |---------- | -------------|-----------------|------------------|---------------------- | |||
| 2024-05-14 | TPU v5e-8 | bfloat16 | 512 | 2048 | 1024 | 1024 | 8700 | |||
| 2024-05-14 | TPU v5e-8 | int8 | 1024 | 2048 | 1024 | 1024 | 8746 | |||
| 2024-06-13 | TPU v5e-1 | bfloat16 | 1024 | 2048 | 1024 | 1024 | 4249 | |||
There was a problem hiding this comment.
The v5e-1 number looks great! The gap is huge, I'm wondering the v5-8 data parallel didn't compute each token locally.
There was a problem hiding this comment.
+1. Since we are sharding on batch for Gemma 2B, even at naive case (duplicate weights) v5e-8 should have 8 * 4249 = 33k toks/sec
There was a problem hiding this comment.
The prefills are replicated (8 chips computing the same thing) because we are sharding on batch and prefill is of batch=1. There might be other issues. Overall we should recommand v5e-1 for gemma-2b instead.
Yeah, we should, we havnet gotten to it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.