Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom release command in aicoe-ci #77

Open
vpavlin opened this issue Nov 6, 2020 · 6 comments
Open

Enable custom release command in aicoe-ci #77

vpavlin opened this issue Nov 6, 2020 · 6 comments
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@vpavlin
Copy link

vpavlin commented Nov 6, 2020

Is your feature request related to a problem? Please describe.
Currently aicoe-ci simply uses git branch & git tag to produce a release. In some cases (e.g. odh-manifests) there are additional steps needed to produce the release successfully.

Describe the solution you'd like
It would be ideal if aicoe-ci allowed to specify a release command with well documented expectations/outcomes. Then we could use for example a Makefile to define the release process and simply use that in the pipeline

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@harshad16
Copy link
Member

Thanks for such a descriptive issue.
We would have to look at the base image requirement first to accommodate the release based on the script.
As the method used by the script should be available in the base image, processing that request.

@harshad16 harshad16 added the good first issue Good for newcomers label Nov 30, 2020
@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Feb 9, 2021
@sesheta
Copy link
Contributor

sesheta commented Jul 3, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2021
@harshad16
Copy link
Member

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 16, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2021
@sesheta
Copy link
Contributor

sesheta commented Nov 15, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2021
@harshad16
Copy link
Member

/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants