Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SUNLinSolWrapper in NewtonSolver #1164

Closed
dweindl opened this issue Jul 19, 2020 · 1 comment
Closed

Use SUNLinSolWrapper in NewtonSolver #1164

dweindl opened this issue Jul 19, 2020 · 1 comment
Assignees
@dweindl
Labels
c++ refactoring
Milestone
Improve steady st...

Comments

@dweindl
Copy link
Member

dweindl commented Jul 19, 2020

We have C++ wrappers for the Sundials linear solvers, but the NewtonSolvers still use the raw objects. This makes those classes unnecessarily complex. Should use those wrappers there.
@paulstapor
Copy link
Contributor

That one is already part of #1073 , but makes sense to keep this in an issue of its own, as this one is larger.

@paulstapor paulstapor mentioned this issue Jul 20, 2020
Open
9 tasks
dweindl added a commit to dweindl/AMICI that referenced this issue Sep 30, 2024
@dweindl
Refactor SUNLinSolWrapper
ea082ee 
* Make it consistent that SUNLinSolWrapper always holds the associated matrix.
* Always use SUNMatrixWrapper instead of raw SUNMatrix objects

This makes it a bit easier to finally address AMICI-dev#1164.
@dweindl dweindl mentioned this issue Sep 30, 2024
Merged
@dweindl dweindl self-assigned this Sep 30, 2024
dweindl added a commit to dweindl/AMICI that referenced this issue Sep 30, 2024
@dweindl
Refactor NewtonSolver
9a79289 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
@dweindl dweindl mentioned this issue Sep 30, 2024
Merged
dweindl added a commit to dweindl/AMICI that referenced this issue Sep 30, 2024
@dweindl
Refactor NewtonSolver
f7bd3f8 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
dweindl added a commit to dweindl/AMICI that referenced this issue Sep 30, 2024
@dweindl
Refactor NewtonSolver
ecc025e 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
dweindl added a commit that referenced this issue Oct 1, 2024
@dweindl
Refactor SUNLinSolWrapper (#2520)
be02a6e 
* Make it consistent that SUNLinSolWrapper always holds the associated matrix
* Always use SUNMatrixWrapper instead of raw SUNMatrix objects
* Implement declared but missing move assignment

This makes it a bit easier to finally address #1164.
dweindl added a commit to dweindl/AMICI that referenced this issue Oct 1, 2024
@dweindl
Refactor NewtonSolver
51ff7ce 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
dweindl added a commit to dweindl/AMICI that referenced this issue Oct 3, 2024
@dweindl
Refactor NewtonSolver
0b5ac36 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
dweindl added a commit to dweindl/AMICI that referenced this issue Oct 3, 2024
@dweindl
Refactor NewtonSolver
cda7aac 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
dweindl added a commit to dweindl/AMICI that referenced this issue Oct 3, 2024
@dweindl
Refactor NewtonSolver
00602c8 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
dweindl added a commit to dweindl/AMICI that referenced this issue Oct 3, 2024
@dweindl
Refactor NewtonSolver
39dfa38 
Use SUNLinSolWrapper. Get rid of subclasses. Simplify.

Closes AMICI-dev#1164.

We should also be able to get rid of the remaining data members,
but that's for another time...
@dweindl dweindl closed this as completed in f66f0b0 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
c++ refactoring
Projects
None yet
Milestone
Improve steady state solver code
Development

No branches or pull requests
2 participants
@paulstapor @dweindl