-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMICI does not handle conditions for parameters governed by rate rules #1750
Labels
Comments
Hi Matthias, thanks for reporting. Agreed that it should work as you expected. We'll fix that. |
@dweindl thanks |
dweindl
added
enhancement
PEtab
PEtab-import related
SBML
SBML import related
and removed
new
Newly created
labels
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi all,
trying to load the attached PETab problem
icg_petab_v2.zip
but getting the following error.
This is a simple model which has the following rate rule
As part of my conditions I want to set
IVDOSE_icg[t=0] = value
. I assume you handle parameters different then species and compartments, but this is not correct. You have to split the set of parameters in constant parameters and parameters governed by rate rules. Parameters governed by rate rules are just state variables in the ODE and everything which is allowed for species state variables and compartment state variables must also work for parameter state variables!I.e. the more correct way for the condition table description in
https://petab.readthedocs.io/en/latest/documentation_data_format.html#condition-table
should be
instead of
Could you please support the setting of initial conditions for parameters governed by rate rules? This mathematical construct occurs in many models and it would be completely unnatural to encode such parameters as
dummy
species or compartments just to get PETab to work.Code example with full error stack below.
results in
The text was updated successfully, but these errors were encountered: