Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up SuiteSparse upgrade #2514

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 27, 2024

  • don't build more than necessary (no shared libs)
  • don't include suitesparse installation directory in sdist

* don't build more than necessary (no shared libs)
* don't include suitesparse installation directory in sdist
@dweindl dweindl marked this pull request as ready for review September 27, 2024 14:26
@dweindl dweindl requested a review from a team as a code owner September 27, 2024 14:26
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (9a81ad1) to head (378af4a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2514      +/-   ##
===========================================
- Coverage    77.70%   77.68%   -0.03%     
===========================================
  Files          324      324              
  Lines        20946    20946              
  Branches      1451     1451              
===========================================
- Hits         16277    16271       -6     
- Misses        4666     4672       +6     
  Partials         3        3              
Flag Coverage Δ
cpp 73.42% <ø> (-0.03%) ⬇️
cpp_python 34.09% <ø> (ø)
petab 36.61% <ø> (ø)
python 72.23% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@dweindl dweindl added this pull request to the merge queue Sep 27, 2024
Merged via the queue into AMICI-dev:develop with commit 8ce245a Sep 27, 2024
21 of 22 checks passed
@dweindl dweindl deleted the fixup_suitesparse branch September 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants