CI: Re-enable benchmark model gradient checks / prettify gradient check output #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dweindl
commented
Oct 2, 2024
•
dweindl
commented
- Make the result more informative and more readable.
- Re-enable some test problems, use stricter tolerances for some at least (Reduce tolerances in benchmark model gradient checks #2511)
- More problem-specific settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2524 +/- ##
========================================
Coverage 77.78% 77.78%
========================================
Files 325 325
Lines 21047 21047
Branches 1473 1473
========================================
Hits 16371 16371
Misses 4649 4649
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. |
dweindl
force-pushed
the
prettify_gradcheck
branch
2 times, most recently
from
2673b2f
to
99b6eba
Compare
dweindl
changed the title
FFroehlich
approved these changes
Oct 9, 2024
…ck output * Make the result more informative and more readable. * Re-enable some test problems, use stricter tolerances for some at least AMICI-dev#967 * More problem-specific settings
dweindl
force-pushed
the
prettify_gradcheck
branch
from
cc547cd
to
b52340e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.