Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3.13 to test matrix #2553

Merged
merged 2 commits into from
Oct 19, 2024
Merged

add 3.13 to test matrix #2553

merged 2 commits into from
Oct 19, 2024

Conversation

FFroehlich
Copy link
Member

python 3.13 was released on Oct 7, 2024: https://docs.python.org/3.13/whatsnew/3.13.html

@FFroehlich FFroehlich requested a review from a team as a code owner October 19, 2024 11:44
@FFroehlich
Copy link
Member Author

I believe we should also drop python 3.9 support, right?

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (8f0c8fb) to head (9c92790).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2553      +/-   ##
===========================================
- Coverage    77.78%   77.75%   -0.04%     
===========================================
  Files          325      325              
  Lines        21852    21852              
  Branches      1473     1473              
===========================================
- Hits         16998    16991       -7     
- Misses        4827     4834       +7     
  Partials        27       27              
Flag Coverage Δ
cpp 73.62% <ø> (-0.04%) ⬇️
cpp_python 34.20% <ø> (ø)
petab 37.06% <ø> (ø)
python 72.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl
Copy link
Member

dweindl commented Oct 19, 2024

I believe we should also drop python 3.9 support, right?

We did, didn't we? If there's anything left -- yes we should.

#2391

@FFroehlich
Copy link
Member Author

I believe we should also drop python 3.9 support, right?

We did, didn't we? If there's anything left -- yes we should.

#2391

oh true! found one tiny leftover

Copy link

sonarcloud bot commented Oct 19, 2024

@FFroehlich FFroehlich added this pull request to the merge queue Oct 19, 2024
Merged via the queue into develop with commit 91054b3 Oct 19, 2024
31 of 32 checks passed
@FFroehlich FFroehlich deleted the test_py313 branch October 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants