-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParticleContainer: Allocator Could be Runtime? #3643
Comments
This can already be done by setting the templated allocator to Currently with |
Thanks @AlexanderSinn, I was not aware of that. I chatted with @WeiqunZhang confirming that we should be good to use the Yes, let's add a helper for setting all components at once. |
The allocator in the
ParticleContainer
classes is a template argument, as in low level C++ objects likestd::vector
et al.I think this is a bit of a design issue, impacting at least for me:
in downstream codes and pyAMReX, because every template argument needs to be specialized, compiled, linked, etc.
@WeiqunZhang @atmyers do you think that long-term, we could make the PC classes using the allocator as a runtime argument, as we do in MultiFabs? This would simplify a lot for me downstream.
The text was updated successfully, but these errors were encountered: