Skip to content

Commit

Permalink
Decouple DataExplorer CSS class names with those of Observability
Browse files Browse the repository at this point in the history
Signed-off-by: Miki <[email protected]>
  • Loading branch information
AMoo-Miki committed Jan 31, 2024
1 parent 6ebb208 commit 402e48f
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
$osdHeaderOffset: $euiHeaderHeightCompensation;

.deSidebar {
.dataExplorerSidebar {
height: 100%;

@include ouiBreakpoint("xs", "s", "m") {
Expand All @@ -9,14 +9,14 @@ $osdHeaderOffset: $euiHeaderHeightCompensation;
}
}

.deLayout {
.dataExplorerLayout {
height: calc(100vh - #{$osdHeaderOffset});

&__canvas {
height: 100%;
}
}

.headerIsExpanded .deLayout {
.headerIsExpanded .dataExplorerLayout {
height: calc(100vh - #{$osdHeaderOffset * 2});
}
4 changes: 2 additions & 2 deletions src/plugins/data_explorer/public/components/app_container.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const AppContainer = ({ view, params }: { view?: View; params: AppMountPa

// Render the application DOM.
return (
<EuiPage className="deLayout" paddingSize="none">
<EuiPage className="dataExplorerLayout" paddingSize="none">
{/* TODO: improve fallback state */}
<Suspense fallback={<div>Loading...</div>}>
<Context {...params}>
Expand All @@ -46,7 +46,7 @@ export const AppContainer = ({ view, params }: { view?: View; params: AppMountPa
<EuiResizableButton />

<EuiResizablePanel initialSize={80} minSize="65%" mode="main" paddingSize="none">
<EuiPageBody className="deLayout__canvas">
<EuiPageBody className="dataExplorerLayout__canvas">
<MemoizedCanvas {...params} />
</EuiPageBody>
</EuiResizablePanel>
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data_explorer/public/components/no_view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const NoView = () => {
return (
<EuiPageTemplate
template="centeredContent"
className="deLayout"
className="dataExplorerLayout"
pageContentProps={{
role: 'alertdialog',
color: 'plain',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.deSidebar {
&_panel {
.dataExplorerSidebar {
&__panel {
border-top: 0;
}

&_dataSource {
&__dataSource {
border-bottom: $euiBorderThin !important;
}
}
6 changes: 3 additions & 3 deletions src/plugins/data_explorer/public/components/sidebar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ export const Sidebar: FC = ({ children }) => {
);

return (
<EuiPageSideBar className="deSidebar" sticky>
<EuiPageSideBar className="dataExplorerSidebar" sticky>
<EuiSplitPanel.Outer
className="eui-yScroll deSidebar_panel"
className="eui-yScroll dataExplorerSidebar__panel"
hasBorder={true}
borderRadius="none"
color="transparent"
Expand All @@ -102,7 +102,7 @@ export const Sidebar: FC = ({ children }) => {
paddingSize="s"
grow={false}
color="transparent"
className="deSidebar_dataSource"
className="dataExplorerSidebar__dataSource"
>
<DataSourceSelectable
dataSources={activeDataSources}
Expand Down

0 comments on commit 402e48f

Please sign in to comment.