Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13: Gallery view: details widget #28

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

#13: Gallery view: details widget #28

wants to merge 7 commits into from

Conversation

prokawsar
Copy link
Collaborator

@prokawsar prokawsar commented Apr 10, 2024

@prokawsar prokawsar self-assigned this Apr 10, 2024
@prokawsar prokawsar linked an issue Apr 10, 2024 that may be closed by this pull request
@prokawsar prokawsar changed the title Details widgets improvements #13 Gallery view: details widget Apr 14, 2024
@prokawsar prokawsar marked this pull request as ready for review April 14, 2024 14:28
@kirillt
Copy link
Member

kirillt commented Apr 14, 2024

Somehow images don't load on my device (macOS).

I've checked last build in main ⏤ all good there.

@prokawsar
Copy link
Collaborator Author

Hello @kirillt
I guess, you missed npm i on this branch?
It has a new package for EXIF.

@kirillt
Copy link
Member

kirillt commented Apr 15, 2024

@prokawsar we need all details necessary for successful build be commited into the repo. This way artifacts from CI would be functional.

@kirillt
Copy link
Member

kirillt commented Apr 15, 2024

This is the build where I've tested macOS app: https:/ARK-Builders/ARK-Gallery/actions/runs/8680080369

@kirillt kirillt changed the title #13 Gallery view: details widget #13: Gallery view: details widget Apr 23, 2024
@prokawsar
Copy link
Collaborator Author

This is the error that causes no view after selecting the image folder.
Screenshot 2024-05-07 at 9 15 09 AM

It's happening for using exifreader package for reading the EXIF of image.
Package link: https:/mattiasw/ExifReader

@alvinosh I guess, it's about tauri csp rules?
Let's see if you can solve that error, or I will find a new package for EXIF.

@kirillt
Copy link
Member

kirillt commented Jun 13, 2024

@alvinosh if we could find pure Rust solution for EXIF, that would be great because we could reuse it for other platforms/apps.

@prokawsar
Copy link
Collaborator Author

@kirillt @alvinosh
It's working fine on 'tauri dev' now.
I think, it's ready for test now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery view: details widget
2 participants