Added swd_uninit_debug() function. Used in nRF5x reset routine and flash uninit #175
Conversation
| __attribute__((weak)) void swd_set_target_reset(uint8_t asserted) | ||
| { | ||
| (asserted) ? PIN_nRESET_OUT(0) : PIN_nRESET_OUT(1); | ||
| } | ||
|
|
||
| // This function is currently never called, see swd_set_target_state_sw() instead |
There was a problem hiding this comment.
This is in use by some targets
There was a problem hiding this comment.
Ok, will remove comment
| } | ||
| else { | ||
| else { | ||
| swd_init_debug(); |
There was a problem hiding this comment.
Were there problems without swd_init_debug()?
There was a problem hiding this comment.
No, but since we do uninit_debug() in the asserted statement above, we have to do init debug again here? Or can we always assume swd_set_target_reset() will be called with asserted == False after it has been called with asserted == True? Then i wouldnt have to call uninit_debug() in the asserted statement above, and then i wouldnt have to call init_debug in the NOTasserted statement here.
There was a problem hiding this comment.
I'm not sure if that sequence can be guaranteed. What you have here is good.
|
@mbed-bot: TEST |
|
Do you have the log of the failing mbed-bot testing? |
|
It doesn't look like this was a real failure. I'll re-trigger. |
|
@mbed-bot: TEST |
1 similar comment
|
@mbed-bot: TEST |
| // Enable debug again because TARGET RESET might have disabled it | ||
| if (!swd_write_word(DBG_HCSR, DBGKEY | C_DEBUGEN)) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
This line is causing tests to fail. The sequence here is to turn on the reset vector catch and then perform a hardware reset so the device is halted right at boot. By writing to the DHCSR here the C_HALT bit gets written to 0 causing the processor to start running. Is this change required for the NRF51 or NRF52 to work correctly?
There was a problem hiding this comment.
Well, since its never used by the nRF51 nor the nRF52, this line is not necessary. It was added because the set_target_reset(0) might have disabled the debug connection. I can remove it.
… for nRF5x, as well as target_flash.c uninit.
|
@mbed-bot: TEST |
No description provided.