Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually add the solution resistance to the ECMs without it #2

Open
ma-sadeghi opened this issue Sep 11, 2023 · 1 comment
Open

Manually add the solution resistance to the ECMs without it #2

ma-sadeghi opened this issue Sep 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ma-sadeghi
Copy link
Collaborator

Currently, we exclude those ECMs without a solution resistance element. This is suboptimal, because we lose some potentially valuable ECMs from the pool. This can be fixed (to some extent) by manually adding the solution resistance to those ECMs without it.

@ma-sadeghi ma-sadeghi added the enhancement New feature or request label Sep 11, 2023
@ma-sadeghi
Copy link
Collaborator Author

After discussion with @RunzeZhang123, it's better if this was fixed at the Julia side, because if we manually add a resistance too those ECMs without one, we need to re-fit the component values, whereas if somehow we can tell the Julia program to "always" include a solution resistance, re-fitting is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant