-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Blumble zone pollen brushing crash #182
Comments
This line seems to be the cause. Line 70 in cbbea5d
In general, NEVER use null for an itemstack. if you must, use Itemstack.EMPTY instead. However, I strongly am suspicious on the supposed performance benefit of setting these fields to null... My use case was I needed the item directly from the context so I can check if it is in my brushing allowed tags or has brushing tool actions. So isHolding was not enough and I used an accessor to get that field. In vanilla, this field is never null. So this was a behavior change by Canary that forced me to add a null check when in vanilla, itemstack should never be null. |
should be fixed in the new updates. |
canary-mc1.20.1-0.2.7
Expected Behavior
Brushing suspicious pollen in the mod "The bumble zone" like Minecraft Archaeology
https://modrinth.com/mod/the-bumblezone
Actual Behavior
Game crashes.
Reproduction Steps
Other Information
Creator of The bumble zone added a Workaround to at least prevent crashes, but the pollen still doesn't brush.
According to creator the crash is caused by passing null as the heldItem into EntityCollisionContext.
crash-2023-11-08_16.25.11-server.txt
crash-2023-11-08_16.25.14-client.txt
The text was updated successfully, but these errors were encountered: