Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of AcalaUncheckedExtrinsic #1428

Closed
4 of 5 tasks
xlc opened this issue Sep 22, 2021 · 3 comments
Closed
4 of 5 tasks

Follow up of AcalaUncheckedExtrinsic #1428

xlc opened this issue Sep 22, 2021 · 3 comments

Comments

@xlc
Copy link
Member

xlc commented Sep 22, 2021

Follow up #1423

@xlc xlc added a-evm labels Sep 22, 2021
@zjb0807 zjb0807 mentioned this issue Oct 7, 2021
@zjb0807
Copy link
Member

zjb0807 commented Oct 8, 2021

let msg_hash = msg.hash(); // TODO: consider rewirte this to use `keccak_256` for hashing because it could be faster

The hash of keccak_256 has been used here, so should not be needed here.

https:/rust-blockchain/ethereum/blob/145923737eedb053405a8bd0a8dd72e6bc446f14/src/transaction.rs#L204

@xlc
Copy link
Member Author

xlc commented Oct 8, 2021

Keccak256::digest does the hash in wasm runtime, but keccak_256 does the have in native so could be faster. But there is overhead of crossing wasm boundary so it may end up faster or slower. That's why we need to benchmark to decide which one is better.

@zjb0807
Copy link
Member

zjb0807 commented Feb 13, 2022

@xlc xlc closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants