Add notifications support for mattermost #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
December 29, 2016 16:24
|
Yay? Nay? ;-) |
|
Hey, looks ok. The new option override refactor seems to have introduced a few conflicts. Please take a look at those and I can take a look at merging in this provider. |
|
Hey @jhixson74 |
…hange in health check status. (#166)
…based on regular expressions (#164) * #145 notif-selection based on regular expressions is implemented * #145 use consul from vagrant for tests * #145 blacklisting services, nodes and checks by regexps implemented * #145 test for getProfileForEntity is simplified * #145 better explanation of regexps for profile activation, disabling health checks * #145 get rid of separate structs for keeping notifier configuration * #145 notifier names are constant per notifier type * #145 variable overrides in the notification profiles are implemented * #145 add go get command for imdario/mergo to travis * #145 re-add imdario/mergo to Godeps * #145 check that notifier exists before returning * #145 copy the notifier before overriding parameters * #145 use hashes of notifiers as keys in send-builtin * #145 remove debug print * Fix ID discrepency
#171) NotifName returns 'awsns' string and should return 'awssns'
Added documentation for enabling Slack "detailed" notification mode.
added 7 commits
February 14, 2017 09:43
|
I thought I had this merged with no conflicts. Boo. Blah. ;-) |
|
ok, merged. I tested this and it's working. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.