Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #66 - missing database name create_engine() crash #67

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix issue #66 - missing database name create_engine() crash #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/sqlalchemy_ingres/pyodbc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ def create_connect_args(self, url):

conn_list = []
conn_list.append('Driver={' + driver_name + '}') # FIXME using concat for now
conn_list.append('Database=' + url.database)
if url.database:
# database may not be needed for dialect operations without a database connnection
conn_list.append('Database=' + url.database)
if not url.host:
conn_list.append('Server=(local)')
else:
Expand Down