Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability for runners to ignore async runtimes. #3495

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Add ability for runners to ignore async runtimes. #3495

merged 3 commits into from
Sep 18, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Sep 17, 2024 •
edited by github-actions bot
Loading

BugDX-3054 Once `optin.unstable.async_runtime` is true no commands sourcing the runtime

This is needed for state refresh and state shell.

@mitchell-as
Add ability for runners to ignore async runtimes.
a9c1c8d 
This is needed for `state refresh` and `state shell`.
mitchell-as
mitchell-as commented Sep 17, 2024
View reviewed changes
internal/runbits/runtime/runtime.go
@@ -49,6 +49,7 @@ type Opts struct {
Archive *checkout.Archive

ValidateBuildscript bool
IgnoreAsync bool
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to this name changing.

@mitchell-as mitchell-as marked this pull request as ready for review September 17, 2024 19:00
@Naatan Naatan merged commit d2a3519 into version/0-46-0-RC1 Sep 18, 2024
7 of 12 checks passed
@Naatan Naatan deleted the mitchell/dx-3054 branch September 18, 2024 21:26
as-builds added a commit that referenced this pull request Sep 18, 2024
@as-builds
Merge branch version/0-46-0-RC1 to adopt changes from PR #3495
a350786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan approved these changes

Assignees
No one assigned
Labels
Test: critical Test: refresh Test: shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @Naatan