Enable linking on other operating systems #666
Conversation
…i into enable-symlinks-172342127
internal/runners/deploy/deploy.go
Outdated
| @@ -146,7 +144,7 @@ func install(installer installable, out output.Outputer) (runtime.EnvGetter, err | |||
| if fail != nil { | |||
| return envGetter, errs.Wrap(fail, "Install failed") | |||
| } | |||
| if ! installed { | |||
| if !installed { | |||
There was a problem hiding this comment.
Please avoid space/syntax changes like this in your PRs
There was a problem hiding this comment.
This is from my formatter running on save. I've tried with both goreturns and gofmt. Which one are you using? Just so I can avoid making these changes without realizing.
There was a problem hiding this comment.
Goland uses its own formatter, but the key thing is that you configure it to only reformat lines that you have actually changed. This should be an option in vscode.
There was a problem hiding this comment.
It looks like this is still a feature request in vscode 😒
microsoft/vscode#44075
Maybe the Go tooling can handle this but I haven't found anything yet.
…i into enable-symlinks-172342127
|
Re the |
| if rt.GOOS == "windows" { | ||
| originalExtenstions := os.Getenv("PATHEXT") | ||
| baseEnv["PATHEXT"] = originalExtenstions + ";.LNK" | ||
| } |
There was a problem hiding this comment.
This doesn't seem necessary for our tests.
There was a problem hiding this comment.
virtualenvironment.GetEnv() now returns an environment with this updated PATHEXT.
There was a problem hiding this comment.
I know, but what does that have to do with the code in this test?
There was a problem hiding this comment.
The report function calls virtualenvironment.GetEnv() so it now includes the updated PATHEXT
…i into enable-symlinks-172342127
https://www.pivotaltracker.com/story/show/172342127