Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension doesn't work on desktop #43

Open
scottwmaxwell opened this issue Mar 23, 2024 · 3 comments
Open

Extension doesn't work on desktop #43

scottwmaxwell opened this issue Mar 23, 2024 · 3 comments

Comments

@scottwmaxwell
Copy link

A blank window appears when selecting a .docx file within VSCodium when the extension is installed.
I restarted VSCodium and did not see a difference.
I'm using macOS with an M1 Pro Chip.

@AdamRaichu
Copy link
Owner

I will look into this. (I can confirm that the extension does not function on my Windows laptop in vscode.)

@AdamRaichu
Copy link
Owner

AdamRaichu commented Mar 30, 2024

Hmm. Testing has revealed some interesting things.

  1. The extension actually works in github.dev. It generates ~30 errors in the console when it does (rendering my test file), but it renders it.
  2. The extension only errors once on desktop, then refuses to keep trying.

The problem seems to be with how either docx-preview (the library I'm using to render) or JSZip, whichever of the two it is, behaves on desktop as opposed to web. (It's the same bundled code, but it just doesn't work on desktop.) If I had to guess, it's because it's retrying the render on the web, but not on the desktop?

In any case, I'm not sure how to fix this right now. Additionally, there isn't really a good alternative to docx-preview either. So for now, I'm going to say it's best to use a different extension. Sorry, I really wish I could fix this. 🤷🏻‍♂️

@AdamRaichu AdamRaichu changed the title Unable to view .docx in VSCodium Extension doesn't work on desktop Mar 30, 2024
@AdamRaichu AdamRaichu pinned this issue Mar 30, 2024
@AdamRaichu
Copy link
Owner

TODO: Check if updating docx-preview to 0.3.1 fixes anything (#48). Also, change to using webpack to compile media folder to reduce file size. (I think it was including jszip twice.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants