Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #225

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Bugfixes #225

merged 6 commits into from
Feb 16, 2024

Conversation

Adanos020
Copy link
Owner

Fixes #223 and #224

@Adanos020 Adanos020 linked an issue Feb 15, 2024 that may be closed by this pull request
Dragging tabs is visually broken #224
Closed
@LennysLounge
Copy link
Contributor

The fix for #224 looks good.

The fix for #223 generally too. Although it is still possible to retain/filter tabs on a node which might leave it empty.

@Adanos020
Copy link
Owner Author

Thank you!
I didn't remove the option to retain and filter tabs on nodes because that would be a breaking change, and I want to publish these fixes in 0.11.2. These methods will become private in 0.12 👍

@Adanos020 Adanos020 merged commit 1a5036c into main Feb 16, 2024
4 checks passed
@Adanos020 Adanos020 deleted the bugfixes branch February 16, 2024 20:00
Adanos020 added a commit that referenced this pull request Feb 28, 2024
@Quinntyx @Adanos020
Added #[derive(Serialize, Deserialize)] to the Style structs under th…
ea50ca1 
…e serde feature (#227)

* Fix docking on empty main surface. (#222)

* Fix docking on empty main surface.

* Update changelog and bump patch number.

* Bugfixes (#225)

* Fix visual bug happening while a tab is being dragged.

* Fix crash on retaining tabs.

* Fix `filter_map_tabs` leaving leaf nodes empty.

* Update changelog

* Revert simple.rs

* Bump patch version number.

* added the derives

---------

Co-authored-by: Adam Gąsior <[email protected]>
Adanos020 added a commit that referenced this pull request Mar 2, 2024
@Quinntyx @Adanos020
Added #[derive(Serialize, Deserialize)] to the Style structs under th…
d835b47 
…e serde feature (#227)

* Fix docking on empty main surface. (#222)

* Fix docking on empty main surface.

* Update changelog and bump patch number.

* Bugfixes (#225)

* Fix visual bug happening while a tab is being dragged.

* Fix crash on retaining tabs.

* Fix `filter_map_tabs` leaving leaf nodes empty.

* Update changelog

* Revert simple.rs

* Bump patch version number.

* added the derives

---------

Co-authored-by: Adam Gąsior <[email protected]>
Adanos020 added a commit that referenced this pull request Mar 26, 2024
@Quinntyx @Adanos020
Added #[derive(Serialize, Deserialize)] to the Style structs under th…
d9bca7d 
…e serde feature (#227)

* Fix docking on empty main surface. (#222)

* Fix docking on empty main surface.

* Update changelog and bump patch number.

* Bugfixes (#225)

* Fix visual bug happening while a tab is being dragged.

* Fix crash on retaining tabs.

* Fix `filter_map_tabs` leaving leaf nodes empty.

* Update changelog

* Revert simple.rs

* Bump patch version number.

* added the derives

---------

Co-authored-by: Adam Gąsior <[email protected]>
Adanos020 added a commit that referenced this pull request Apr 5, 2024
@Adanos020 @Quinntyx
Release 0.12 (#235)
d637fd1 
* Bump crate version number

* Added #[derive(Serialize, Deserialize)] to the Style structs under the serde feature (#227)

* Fix docking on empty main surface. (#222)

* Fix docking on empty main surface.

* Update changelog and bump patch number.

* Bugfixes (#225)

* Fix visual bug happening while a tab is being dragged.

* Fix crash on retaining tabs.

* Fix `filter_map_tabs` leaving leaf nodes empty.

* Update changelog

* Revert simple.rs

* Bump patch version number.

* added the derives

---------

Co-authored-by: Adam Gąsior <[email protected]>

* Upgrade egui and fix clippy

* Fix close buttons

* Fix drag-n-drop (todo: fix overlays).

* Fix overlay

* Fix dragging tabs

* Fix visual bug while dragging and hovering one tab over another

* Fix close buttons again

* Fix more visual glitches while dragging tabs

* Fixed the mysterious resizing of the area occupied by `DockArea` caused by overlays.

* Fix clippy and revert test changes to `simple` example.

* Fix clippy

* Update changelog

* Fix splits in the buttons overlay.

* Add border rounding to style editor in `hello` example

* Update changelog

---------

Co-authored-by: Quinntyx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dragging tabs is visually broken Panic when retaining tabs
2 participants
@Adanos020 @LennysLounge