-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useNativeEvents
should not be a part of the page object out of the box?
#32
Comments
Hm, yeah I can try to make the change and see how it impacts the large codebases at Addepar. Good catch, thank you! |
Just in case |
I've removed it as part of my testing the v2-beta. #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've just observed the following in the codebase
ember-classy-page-object/addon-test-support/-private/page-object.js
Lines 8 to 9 in 714cb45
I believe it should not be here, and if really needed, it should be called on the consumer test setup side.
The
useNativeEvents(
is used to enable the ember-native-dom-helpers, which was needed in the era ofmoduleFor*
tests. Now, for the test suites using modern@ember/test-helpers
, I don't think we need it anymore.Also,
useNativeEvents(
is now removed in the v2-beta of the ec-page-objects, causemoduleFor
test helpers are now removed completelly from@ember/test-helpers
, so I think this invocation would break ember-classy-page-object under ember-cli-page-object@v2 when it's released.So my guess is that we should remove it from here at some point, as a breaking change? @mixonic what do you think?
The text was updated successfully, but these errors were encountered: