Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error when using ember-cli-page-object v2.0.0-beta.4 #39

Closed
ginomiglio opened this issue Aug 18, 2022 · 2 comments
Closed

Build error when using ember-cli-page-object v2.0.0-beta.4 #39

ginomiglio opened this issue Aug 18, 2022 · 2 comments

Comments

@ginomiglio
Copy link

ginomiglio commented Aug 18, 2022

The version of ember-cli-page-object required in package.json is ~v2.0.0-beta.3, which includes the newly-released v2.0.0-beta.4. However, that version converts ember-cli-page-object to a V2 addon, and we now see this error when trying to build our app:

ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object

Our workaround is to force ember-cli-page-object to v2.0.0-beta.3 using yarn resolutions. But it seems like this addon should probably move ember-auto-import to dependencies instead of devDependencies as recommended in the ember-auto-import documentation.

I'll open a PR but I'm not sure if this is a breaking change for consuming apps/addons, so some additional thought might be required there.

@ginomiglio
Copy link
Author

Looks like #38 should fix this actually.

@ginomiglio
Copy link
Author

closing this as #38 has been merged and released as v0.8.0-beta.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant