Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests do not always wait for table to render #1120

Open
gokolo opened this issue Aug 12, 2024 · 0 comments
Open

Integration tests do not always wait for table to render #1120

gokolo opened this issue Aug 12, 2024 · 0 comments

Comments

@gokolo
Copy link

gokolo commented Aug 12, 2024

We are on Ember Table V5.0.6. We used the setupEmberTableForTest(); helper in our tests.
But our integration test are still flaky. It seems that some rendering tasks that are not completed before the tests moves on to the next line despite the await call.

I looked at Ember table's tests and I noticed that settled() is called after render() is called.

This fixed my failing tests but this triggers the no-settled-after-test-helper eslint error.

What can be done to fix this without having to call settled() after render() is called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant