-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECP-8840] "origin" is used from "additionalData" instead of the root property. #404
Comments
according to Adyen/adyen-php-api-library#536 (comment) and Adyen/adyen-php-api-library#531 (comment) that validator should not be used anymore. |
Hello @AndreasA, Thank you for raising this issue. We've created an investigation ticket. We'll inform you when we finish the investigation. Best Regards, |
Hey all, Please note that our team fixed this issue. Changes are pushed on: 3.x - fix/develop-3-CS-5934 4.x - fix/CS-5934 branches. This will be available in the next plugin release. Best regards. |
Describe the bug
The "origin" parameter set by the web components is set in the root level not the additionalData level, so in most cases this value is ignored. Especially, as CheckoutStateDataValidator removes origin from the default data as well.
For headless implementations where the product URL might not be set, it would be nice if the correct origin is used.
Might even be something that should be changed in the php-api-library, so that CheckoutStateDataValidator does not remove origin, but then the check would still be wrong as you would need to check if it is set in $request.
Versions
Shopware version: 6.5.3.3
Plugin version: 3.12.1
The text was updated successfully, but these errors were encountered: