Skip to content

Commit

Permalink
comments cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
turadg committed Nov 2, 2023
1 parent f3060e3 commit f7e488b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion makeDockerfile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ RUN /usr/src/upgrade-test-scripts/start_ag0.sh
) {
return `
# PREPARE ${proposalName}
//
# upgrading to ${planName}
FROM use-${lastProposal.proposalName} as prepare-${proposalName}
ENV UPGRADE_TO=${planName}
Expand Down
5 changes: 2 additions & 3 deletions proposals/55:statom-vaults/add-collateral.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const test = anyTest;
const assetInfo = {
repo: {
release:
// TODO update with actual release https:/0xpatrickdev/agoric-vault-collateral-proposal/releases/tag/2023-16-10-agoric-3
'https:/dckc/agoric-vault-collateral-proposal/releases/tag/v0.13.0-beta1',
url: 'https:/0xpatrickdev/agoric-vault-collateral-proposal',
name: 'agoric-vault-collateral-proposal',
Expand Down Expand Up @@ -103,18 +104,16 @@ const makeTestContext = async (t, io = {}) => {
tmpName = tmpNameAmbient,
} = io;

// @@ const src = makeWebRd(staticConfig.assetBase, { fetch });
const src = makeWebRd(staticConfig.releaseAssets, { fetch });

const td = await new Promise((resolve, reject) =>
tmpName({ prefix: 'assets' }, (err, x) => (err ? reject(err) : resolve(x))),
);
const dest = makeFileRW(td, { fsp, path });
// @@ Error: `t.teardown()` is not allowed in hooks
// FIXME Error: `t.teardown()` is not allowed in hooks
// t.teardown(() => assets.remove());
const assets = makeWebCache(src, dest);
// assume filenames don't overlap
//@@alt const bundleAssets = makeWebCache(src.join('bundles/'), dest);
const bundleAssets = makeWebCache(src, dest);
console.log(`bundleAssets: ${bundleAssets}`);

Expand Down
1 change: 1 addition & 0 deletions upgrade-test-scripts/lib/econHelpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { agd, agops } from './cliHelper.js';
import { ATOM_DENOM, CHAINID, VALIDATORADDR } from './constants.js';
import { executeOffer } from './commonUpgradeHelpers.js';

// TODO return the id of the new vault so subsquent commands can use it
export const openVault = (address, mint, collateral) => {
return executeOffer(
address,
Expand Down

0 comments on commit f7e488b

Please sign in to comment.