add the ability to find details for multiple vats #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
force-pushed
the
172-vatDetailsForSynthChain
branch
from
cd740b0
to
e7a283b
Compare
turadg
reviewed
Sep 6, 2024
| @@ -62,6 +62,14 @@ const makeSwingstore = db => { | |||
| if (!targetVat) throw Error(`vat not found: ${vatName}`); | |||
| return targetVat; | |||
| }, | |||
| /** @param {string} vatName */ | |||
There was a problem hiding this comment.
this one's a substring, not a name
would it help to support regexp?
There was a problem hiding this comment.
I changed the name.
I can't think of a reason to want a regexp here. YAGNI
turadg
approved these changes
Sep 9, 2024
| @@ -62,6 +62,14 @@ const makeSwingstore = db => { | |||
| if (!targetVat) throw Error(`vat not found: ${vatName}`); | |||
| return targetVat; | |||
| }, | |||
| /** @param {string} string a string to search for within the vat name. */ | |||
There was a problem hiding this comment.
using string as the type, the param name, and the doc word reads slowly. consider,
Suggested change
| /** @param {string} string a string to search for within the vat name. */ | |
| /** @param {string} substring to search for within the vat name. */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share some tools built for vaults-auctions upgrade
See: #172