Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: drop a:vaults-auctions/ from a3p-integration #10053

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Chris-Hibbert
Copy link
Contributor

refs: #9928

Description

Clean up in a3p-integration, as a follow-up to the vaults&auctions release on mainNet, and addition of that release to agoric-3-proposals.

Security Considerations

N/A

Scaling Considerations

N/A

Documentation Considerations

I will add more details of this process to CONTRIBUTING in a-3-p.

Testing Considerations

keeping things clean so testing can continue.

Upgrade Considerations

upgrade and iterate!

@Chris-Hibbert Chris-Hibbert self-assigned this Sep 10, 2024
@Chris-Hibbert Chris-Hibbert added the force:integration Force integration tests to run on PR label Sep 10, 2024
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to update the base image in a3p-integration/package.json

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh nevermind, it's at latest. I'm wondering if we should make the base version explicit so that adding a proposal in a3p doesn't immediately affect agoric-sdk

@Chris-Hibbert
Copy link
Contributor Author

Ugh nevermind, it's at latest.

Thanks. I was going to reply saying that was my understanding.

I'm wondering if we should make the base version explicit so that adding a proposal in a3p doesn't immediately affect agoric-sdk

I don't have the Docker-fu to have an opinion on that. In any case, that's after this change.

@Chris-Hibbert Chris-Hibbert added the automerge:rebase Automatically rebase updates, then merge label Sep 10, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: caa2720
Status: ✅  Deploy successful!
Preview URL: https://d8b72bb9.agoric-sdk.pages.dev
Branch Preview URL: https://9928-drop-va-from-a3p-i.agoric-sdk.pages.dev

View logs

@mergify mergify bot merged commit f6191c2 into master Sep 10, 2024
80 checks passed
@mergify mergify bot deleted the 9928-drop-VA-from-a3p-i branch September 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge contract-upgrade force:integration Force integration tests to run on PR test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants