SPIKE: rotate EC membership #10105
SPIKE: rotate EC membership #10105
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
cfe20f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f371c254.agoric-sdk.pages.dev |
| Branch Preview URL: | https://rs-ec-changes.agoric-sdk.pages.dev |
rabi-siddique
force-pushed
the
rs-ec-changes
branch
from
6557368
to
2dbffcf
Compare
rabi-siddique
force-pushed
the
rs-ec-changes
branch
from
e5f772b
to
dd85537
Compare
|
For the title, consider "SPIKE: rotate EC membership" This exploratory work is great, but I expect we'll want to break it into a number of PRs when we add tests and such. |
packages/governance/src/committee.js
Outdated
| shutdown() { | ||
| zcf.shutdown('EC Charter Shutdown'); | ||
| }, |
There was a problem hiding this comment.
Let's not add this now. The Committee is the sole holder of the set of questions that have been voted on, and I'd prefer we find a way to write this to vstorage before killing the vats.
The reason to do something like this is to prevent ex-members from voting, so let's do that directly. Try adding a method like stopAddingVotes() that sets a flag that blocks use of addQuestion() or getPoserInvitation().
There was a problem hiding this comment.
noted as a design choice in
There was a problem hiding this comment.
If we're going to add this method, it should be tested in unit tests and some test that does an upgrade. Either a bootstrap test or a3p-integration would do.
| consume: { economicCommitteeCreatorFacet, econCharterKit }, | ||
| }) => { | ||
| console.log('Shutting down old EC Committee'); | ||
| await E(economicCommitteeCreatorFacet).shutdown(); |
There was a problem hiding this comment.
This method is available on the new committee, but not the old one, unless the old one gets upgraded.
| @@ -179,6 +180,9 @@ export const start = async (zcf, privateArgs, baggage) => { | |||
| }, | |||
| makeCharterMemberInvitation: () => | |||
| zcf.makeInvitation(charterMemberHandler, INVITATION_MAKERS_DESC), | |||
| shutdown: () => { | |||
There was a problem hiding this comment.
If we're going to add this method, it should be tested in unit tests and some test that does an upgrade. Either a bootstrap test or a3p-integration would do.
packages/governance/src/committee.js
Outdated
| shutdown() { | ||
| zcf.shutdown('EC Charter Shutdown'); | ||
| }, |
There was a problem hiding this comment.
If we're going to add this method, it should be tested in unit tests and some test that does an upgrade. Either a bootstrap test or a3p-integration would do.
|
|
||
| console.log('Shutting down old EC Charter'); | ||
| const { creatorFacet } = E.get(econCharterKit); | ||
| await E(creatorFacet).shutdown(); |
There was a problem hiding this comment.
This method is available on the new committee, but not the old one, unless the old one got upgraded.
rabi-siddique
force-pushed
the
rs-ec-changes
branch
from
dd85537
to
6d31293
Compare
rabi-siddique
force-pushed
the
rs-ec-changes
branch
from
6d31293
to
5dfbe1b
Compare
| @@ -179,6 +179,9 @@ export const start = async (zcf, privateArgs, baggage) => { | |||
| }, | |||
| makeCharterMemberInvitation: () => | |||
| zcf.makeInvitation(charterMemberHandler, INVITATION_MAKERS_DESC), | |||
| shutdown: () => { | |||
There was a problem hiding this comment.
adding shutdown methods to both contracts in 1 commit is awkward - I expect them to land in separate PRs, since the testing considerations are different.
rabi-siddique
force-pushed
the
rs-ec-changes
branch
from
5dfbe1b
to
866baae
Compare
rabi-siddique
force-pushed
the
rs-ec-changes
branch
from
866baae
to
cfe20f4
Compare
|
This SPIKE served the purpose of exploring feasibility. Nice work! Product development proceeds in other PRs. |
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations