test(a3p): create a3p test for replace electorate core eval #10241
+595
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5b5407e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fc2f4597.agoric-sdk.pages.dev |
| Branch Preview URL: | https://fraz-replace-committee-a3p.agoric-sdk.pages.dev |
frazarshad
force-pushed
the
rs-faraz-replace-charter
branch
from
ffce1a7
to
aef84d0
Compare
dckc
reviewed
Oct 8, 2024
| } from './agoric-tools.js'; | ||
| import { waitUntil } from './utils.js'; | ||
|
|
||
| test('new committee should be able to vote', async t => { |
There was a problem hiding this comment.
I suggest splitting this into 2 tests:
- a test for accepting invitations, which is specific to this upgrade, and belongs here in
b:replace... - a test for making vault parameter changes, which should be tested on every upgrade, so belongs in
z:acceptance
dckc
reviewed
Oct 8, 2024
| @@ -0,0 +1,5 @@ | |||
| export const waitUntil = async waitTime => { | |||
There was a problem hiding this comment.
Suggested change
| export const waitUntil = async waitTime => { | |
| export const waitUntil = async (waitTime, { setTimeout = globalThis.setTimeout, now = Date.now } = {}) => { |
see
dckc
reviewed
Oct 8, 2024
| -1, | ||
| fromCapData, | ||
| ); | ||
| await waitUntil(latestQuestion.closingRule.deadline); |
There was a problem hiding this comment.
Suggested change
| await waitUntil(latestQuestion.closingRule.deadline); | |
| const { setTimeout } = globalThis; | |
| const { now } = Date; | |
| await waitUntil(latestQuestion.closingRule.deadline, { setTimeout, now }); |
dckc
reviewed
Oct 8, 2024
| @@ -0,0 +1,5 @@ | |||
| export const waitUntil = async waitTime => { | |||
| while (Math.floor(Date.now() / 1000) < waitTime) { | |||
There was a problem hiding this comment.
Why wait repeatedly? Why not just compute the difference between waitTime and now and wait once?
dckc
reviewed
Oct 8, 2024
| @@ -0,0 +1,5 @@ | |||
| export const waitUntil = async waitTime => { | |||
| while (Math.floor(Date.now() / 1000) < waitTime) { | |||
There was a problem hiding this comment.
Suggested change
| while (Math.floor(Date.now() / 1000) < waitTime) { | |
| while (Math.floor(now() / 1000) < waitTime) { |
rabi-siddique
force-pushed
the
rs-faraz-replace-charter
branch
from
6a3afcb
to
78581b1
Compare
frazarshad
force-pushed
the
fraz/replace-committee-a3p
branch
from
5082910
to
519de18
Compare
test: wrote tests for new invitation acceptance
chore: rename test title
chore: change order of acceptance
test: fixed issue with invitation acceptance in other packages
chore: fix types in waitUntil
dckc
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Lots of good stuff here. But the EC changes should take place as part of n:upgrade-next; see #10258 .
The z:acceptance stuff could probably land as its own PR. I would expect it to work before or after the change of membership. Hm... maybe that would complicate things.
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "agoricProposal": { | |||
| "type": "/agoric.swingset.CoreEvalProposal", | |||
There was a problem hiding this comment.
IIUC, the plan is no longer to do a separate CoreEvalProposal.
The EC change should take effect as part of the next SoftwareUpgradeProposal. See
This was referenced Oct 17, 2024
test: moved a3p tests to upgrade-next
chore: revert price feed change
test: updates to governance in acceptance tests
chore: remove redundant test
fix: updated upgrade.go to handle opts for replaceElectorate proposal
chore: reduce duplication of config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10138
closes: #10258
Description
A3P tests for the replace electorate core eval. also adds the replace-electorate-core.js script to upgrade.go since it will now be a part of the chain halting upgrade
new tests are as follows:
n:replace-electoratewhich tests for acceptance of new invitationsz:acceptanceSecurity Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations