Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Math.pow workaround #84

Closed
turadg opened this issue Jun 3, 2023 · 1 comment · Fixed by #111
Closed

remove Math.pow workaround #84

turadg opened this issue Jun 3, 2023 · 1 comment · Fixed by #111
Assignees
@iomekam
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@turadg
Copy link
Member

turadg commented Jun 3, 2023

What is the Problem Being Solved?

This and likely other dapps have an unnecessary vestigial Math.pow binding
#82 (comment)

Description of the Design

Remove it from here and anywhere else it can be found

Security Considerations

Test Plan
@turadg turadg added the enhancement New feature or request label Jun 3, 2023
This was referenced Jun 3, 2023
Merged
Merged
@turadg turadg added the good first issue Good for newcomers label Jul 5, 2023
@iomekam
Copy link
Contributor

iomekam commented Jul 12, 2023 •
edited
Loading

Doing a GitHub search of Math.pow in the agoric org, I've only observed this being used in wallet-app

@iomekam iomekam mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iomekam iomekam

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove custom Math.pow implementation Agoric/wallet-app
2 participants
@turadg @iomekam