Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locahost href to use correct url when displaying network url #105

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

iomekam
Copy link
Contributor

@iomekam iomekam commented Jun 28, 2023

Closes #104

@iomekam
Copy link
Contributor Author

iomekam commented Jun 28, 2023

Having trouble getting prettier to work. Here's the error:

iomekam@Ikennas-MacBook-Pro-2 wallet % yarn format
yarn run v1.22.19
$ yarn prettier --write .
$ /Users/iomekam/Documents/agoric/wallet-app/node_modules/.bin/prettier --write .
[error] No matching files. Patterns tried: . !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@turadg, any suggestions?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cac35c6
Status:⚡️  Build in progress...

View logs

@iomekam iomekam force-pushed the connection-setting-localhost-fix branch from a3b44a4 to 8c279b2 Compare June 28, 2023 22:23
@iomekam iomekam marked this pull request as ready for review June 29, 2023 21:33
@iomekam iomekam requested a review from samsiegart June 29, 2023 21:33
@iomekam
Copy link
Contributor Author

iomekam commented Jun 29, 2023

Having trouble getting prettier to work. Here's the error:

iomekam@Ikennas-MacBook-Pro-2 wallet % yarn format
yarn run v1.22.19
$ yarn prettier --write .
$ /Users/iomekam/Documents/agoric/wallet-app/node_modules/.bin/prettier --write .
[error] No matching files. Patterns tried: . !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@turadg, any suggestions?

Per @turadg, prettier doesn't work with .ts files. Since this doesn't block CI, I'll proceed with the change, and the followup to run prettier on these files in the future should be trivial.

Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we can fix the CI/formatting issue. I pushed a commit just to format the code in the meantime and fixed a filename, you can merge as soon as it's green.

@iomekam iomekam enabled auto-merge June 29, 2023 22:38
@iomekam iomekam merged commit d647730 into main Jun 29, 2023
@iomekam iomekam deleted the connection-setting-localhost-fix branch June 29, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localhost connection config should use current hostname
2 participants