ci: prettier check #110
Merged
ci: prettier check #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
reviewed
Jul 11, 2023
wallet/package.json
Outdated
Comment on lines
86
to
87
| "pretty-check": "yarn prettier --check '**/*.{js,jsx,ts,tsx}'", | ||
| "pretty-fix": "yarn prettier --write '**/*.{js,jsx,ts,tsx}'", |
There was a problem hiding this comment.
Please align these commands cwith agoric-sdk:
Suggested change
| "pretty-check": "yarn prettier --check '**/*.{js,jsx,ts,tsx}'", | |
| "pretty-fix": "yarn prettier --write '**/*.{js,jsx,ts,tsx}'", | |
| "lint:format": "yarn prettier --check '**/*.{js,jsx,ts,tsx}'", | |
| "format": "yarn prettier --write '**/*.{js,jsx,ts,tsx}'", |
"format" instead of "pretty" because we could change formatting tools and wouldn't want to reprogram muscle memory. "lint:format" so that the run-s in lint does that one too.
.github/workflows/test.yml
Outdated
| @@ -19,4 +19,5 @@ jobs: | |||
| cache: 'yarn' | |||
| - run: yarn install --frozen-lockfile # optional, --immutable | |||
| - run: cd wallet && yarn lint | |||
| - run: cd wallet && yarn pretty-check | |||
There was a problem hiding this comment.
not necessary if you name the check lint:format.
Deploying with
|
| Latest commit: |
b5e2e25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7c0841d.wallet-app.pages.dev |
| Branch Preview URL: | https://prettier-ci.wallet-app.pages.dev |
turadg
approved these changes
Jul 11, 2023
iomekam
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.