fix: third-party cookies error #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
20de183
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92a6857d.wallet-app.pages.dev |
| Branch Preview URL: | https://fix-cookies-error.wallet-app.pages.dev |
|
Cloudflare deployment isn't working for some reason 🤕 |
The bridge doesn't actually rely on cookies.
samsiegart
approved these changes
Jun 6, 2023
|
Does this fix Agoric/dapp-inter#199 as well? |
No, this has been in production since https:/Agoric/wallet-app/runs/14025919120 You can see the new error message "No access to localStorage" in https://wallet.agoric.app/wallet/static/js/bridge-dapp.5403a070.10d8eac7.js served at https://wallet.agoric.app/wallet/bridge I suppose something changed in their partitioning design since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Agoric/dapp-psm#69 seems to be due to the Bridge connection logic.
Test Plan
Firefox without TPfails silentlyBrave without Shieldsfails silentlyChrome with Third-Party cookies blockedfails loudly with error in console "failed to readlocalStorageproperty from window)