Force register a new schema #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmiri
force-pushed
the
issue-force-register-on-new-schema
branch
from
431c350
to
a931abb
Compare
| if($scope.addSchema.remarks == null) { | ||
| $scope.addSchema.remarks = " Force Register Schema option overriding schema compatibility has been selected." | ||
| } else { | ||
| $scope.addSchema.remarks += " Force Register Schema option overriding schema compatibility has been selected." |
There was a problem hiding this comment.
may be define the remarks in a var, and reuse in both the conditional blocks
There was a problem hiding this comment.
If it is set to += if they add remarks it will be added to the end.
but if they dont set a remark it will then come out as "undefined Force...."
so if block is needed to make sure remarks are not null to give best experience to user. Also copy may change Harishini is just checking on it at the mo i think.
There was a problem hiding this comment.
I meant, if we can define a variable for the remarks string. Currently it is duplicated
…efault partition and replication numbers on a new topic request. Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
programmiri
force-pushed
the
issue-force-register-on-new-schema
branch
from
c5ce243
to
53d4f5b
Compare
…enabled Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force register a new schema also auto select the default partition and replication numbers on a new topic request.
Linked issue
Resolves: #1882
What kind of change does this PR introduce?
What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully